Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 6880236: Use the IAttachmentExecute service to set the Zone.Identifier stream, (Closed)

Created:
9 years, 8 months ago by Joao da Silva
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, Glenn Wilson, abarth-chromium
Visibility:
Public.

Description

Use the IAttachmentExecute service to set the Zone.Identifier stream, when available. This is used to mark files as untrusted, because they were downloaded from the internet. The DownloadTest.CheckInternetZone browser test was failing previously because the Zone.Identifier stream created by the IAttachmentExecute service uses \r\n for newlines, and the test was checking for \n. See also http://codereview.chromium.org/590001, which this should close. BUG=5719 TEST=DownloadTest.CheckInternetZone Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83502

Patch Set 1 #

Total comments: 6

Patch Set 2 : Reviewed, rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -41 lines) Patch
M base/test/test_file_util_win.cc View 1 2 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/download/base_file.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/win_safe_util.h View 1 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/common/win_safe_util.cc View 3 chunks +66 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
Please review. Forgot to upload before sending to the try bots, here are the links: ...
9 years, 8 months ago (2011-04-27 13:21:16 UTC) #1
danno
LGTM, but you should probably get somebody with a little more Windows programming experience than ...
9 years, 8 months ago (2011-04-28 02:32:48 UTC) #2
cpu_(ooo_6.6-7.5)
I notice that SetInternetZoneIdentifier signature changed but there are no updated unittests, so this feature ...
9 years, 8 months ago (2011-04-28 17:59:59 UTC) #3
Joao da Silva
Thanks for reviewing, please have another look. This is tested by DownloadTest.CheckInternetZone in browser_tests. The ...
9 years, 8 months ago (2011-04-28 18:16:27 UTC) #4
cpu_(ooo_6.6-7.5)
9 years, 8 months ago (2011-04-28 22:40:05 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698