Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 6880204: Refactor lithium classes to reduce the number of virtual functions. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.h ('k') | src/x64/lithium-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 672 matching lines...) Expand 10 before | Expand all | Expand 10 after
683 683
684 684
685 void LCodeGen::DoLabel(LLabel* label) { 685 void LCodeGen::DoLabel(LLabel* label) {
686 if (label->is_loop_header()) { 686 if (label->is_loop_header()) {
687 Comment(";;; B%d - LOOP entry", label->block_id()); 687 Comment(";;; B%d - LOOP entry", label->block_id());
688 } else { 688 } else {
689 Comment(";;; B%d", label->block_id()); 689 Comment(";;; B%d", label->block_id());
690 } 690 }
691 __ bind(label->label()); 691 __ bind(label->label());
692 current_block_ = label->block_id(); 692 current_block_ = label->block_id();
693 LCodeGen::DoGap(label); 693 DoGap(label);
694 } 694 }
695 695
696 696
697 void LCodeGen::DoParallelMove(LParallelMove* move) { 697 void LCodeGen::DoParallelMove(LParallelMove* move) {
698 resolver_.Resolve(move); 698 resolver_.Resolve(move);
699 } 699 }
700 700
701 701
702 void LCodeGen::DoGap(LGap* gap) { 702 void LCodeGen::DoGap(LGap* gap) {
703 for (int i = LGap::FIRST_INNER_POSITION; 703 for (int i = LGap::FIRST_INNER_POSITION;
704 i <= LGap::LAST_INNER_POSITION; 704 i <= LGap::LAST_INNER_POSITION;
705 i++) { 705 i++) {
706 LGap::InnerPosition inner_pos = static_cast<LGap::InnerPosition>(i); 706 LGap::InnerPosition inner_pos = static_cast<LGap::InnerPosition>(i);
707 LParallelMove* move = gap->GetParallelMove(inner_pos); 707 LParallelMove* move = gap->GetParallelMove(inner_pos);
708 if (move != NULL) DoParallelMove(move); 708 if (move != NULL) DoParallelMove(move);
709 } 709 }
710 710
711 LInstruction* next = GetNextInstruction(); 711 LInstruction* next = GetNextInstruction();
712 if (next != NULL && next->IsLazyBailout()) { 712 if (next != NULL && next->IsLazyBailout()) {
713 int pc = masm()->pc_offset(); 713 int pc = masm()->pc_offset();
714 safepoints_.SetPcAfterGap(pc); 714 safepoints_.SetPcAfterGap(pc);
715 } 715 }
716 } 716 }
717 717
718 718
719 void LCodeGen::DoInstructionGap(LInstructionGap* instr) {
720 DoGap(instr);
721 }
722
723
719 void LCodeGen::DoParameter(LParameter* instr) { 724 void LCodeGen::DoParameter(LParameter* instr) {
720 // Nothing to do. 725 // Nothing to do.
721 } 726 }
722 727
723 728
724 void LCodeGen::DoCallStub(LCallStub* instr) { 729 void LCodeGen::DoCallStub(LCallStub* instr) {
725 ASSERT(ToRegister(instr->result()).is(rax)); 730 ASSERT(ToRegister(instr->result()).is(rax));
726 switch (instr->hydrogen()->major_key()) { 731 switch (instr->hydrogen()->major_key()) {
727 case CodeStub::RegExpConstructResult: { 732 case CodeStub::RegExpConstructResult: {
728 RegExpConstructResultStub stub; 733 RegExpConstructResultStub stub;
(...skipping 3295 matching lines...) Expand 10 before | Expand all | Expand 10 after
4024 RegisterEnvironmentForDeoptimization(environment); 4029 RegisterEnvironmentForDeoptimization(environment);
4025 ASSERT(osr_pc_offset_ == -1); 4030 ASSERT(osr_pc_offset_ == -1);
4026 osr_pc_offset_ = masm()->pc_offset(); 4031 osr_pc_offset_ = masm()->pc_offset();
4027 } 4032 }
4028 4033
4029 #undef __ 4034 #undef __
4030 4035
4031 } } // namespace v8::internal 4036 } } // namespace v8::internal
4032 4037
4033 #endif // V8_TARGET_ARCH_X64 4038 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.h ('k') | src/x64/lithium-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698