Issue 6880195: Applying this fix:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6880195: Applying this fix: (Closed)

Created:
9 years, 8 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Nick Bray, noelallen_use_chromium

CC:
native-client-reviews_googlegroups.com

Base URL:
http://src.chromium.org/native_client/trunk/src/third_party/scons-2.0.1/

Visibility:
Public.

Description

Applying this fix: http://scons.tigris.org/issues/show_bug.cgi?id=2449 Which we had done in the previous scons version. BUG=None TEST=None R=noelallen@google.com Committed: http://code.google.com/p/nativeclient/source/detail?r=5025

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	README.nacl	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	engine/SCons/Platform/win32.py	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

noelallen_use_chromium

9 years, 8 months ago (2011-04-26 00:45:42 UTC) #3

LGTM

Note to readers, this is a known issue that we solved previously, but lost the
fix, when we upgraded versions of scons.  Python and Scons both have found and
marked this issue as won't fix, so we need to continue patching this in whenever
we upgrade.

Expand Messages | Collapse Messages