Fixed recursive variable in Makefile

Fixed recursive variable in Makefile

DEFECT=13360
TEST=compiled with "emerge-x86-mario ktop"

Change-Id: I76d877eac3cbb66fb334f3a4cb8f3fa1ef4ba1c6

Merge branch 'master' of ssh://gitrw.chromium.org:9222/ktop into ktop


Added missing makefile.

BUG=13360
Change-Id: Id60a7273762e764e33f120005f9db01cd86db249

Changes to kplot for ebuild

BUG=13360
TEST=compiled with emerge and ran on cr48

Change-Id: I585ea57b7b3b86abe6096f4eade724d5ea12ab9f

R=msb@chromium.org,semenzato@chromium.org,ups@chromium.org

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bde760a

[Luigi Semenzato, 2011-04-25 23:28:45]

LGTM with nits:

Can you elaborate just a bit more on the "recursive variable"?  It may not be
immediately clear what you mean to a casual reader of the review.

Thanks!

http://codereview.chromium.org/6880189/diff/1/Makefile
File Makefile (right):

http://codereview.chromium.org/6880189/diff/1/Makefile#newcode28
Makefile:28: name    := $(basename $(notdir $(PWD)))
I'd be bold and remove the previous line instead of commenting it out.

[Paul T, 2011-04-26 00:02:26]

PTAL

http://codereview.chromium.org/6880189/diff/1/Makefile
File Makefile (right):

http://codereview.chromium.org/6880189/diff/1/Makefile#newcode28
Makefile:28: name    := $(basename $(notdir $(PWD)))
On 2011/04/25 23:28:45, Luigi Semenzato wrote:
> I'd be bold and remove the previous line instead of commenting it out.

Fixed.

[Luigi Semenzato, 2011-04-26 00:09:23]

LGTM

On 2011/04/26 00:02:26, Paul T wrote:
> PTAL
> 
> http://codereview.chromium.org/6880189/diff/1/Makefile
> File Makefile (right):
> 
> http://codereview.chromium.org/6880189/diff/1/Makefile#newcode28
> Makefile:28: name    := $(basename $(notdir $(PWD)))
> On 2011/04/25 23:28:45, Luigi Semenzato wrote:
> > I'd be bold and remove the previous line instead of commenting it out.
> 
> Fixed.