Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 6880187: Import json by default, then simplejson. (Closed)

Created:
9 years, 8 months ago by cmp
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Import json by default, then simplejson. Since json is included in Python 2.6 and above, first try importing it, then import simplejson if that fails. Also ensure that any unicode characters are converted to ASCII before checksumming to avoid checksum differences in strings generated by json and simplejson modules. TEST=make_expectations.py runs on Windows using the stock Python in depot_tools Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82946

Patch Set 1 #

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M tools/perf_expectations/make_expectations.py View 1 4 chunks +19 lines, -12 lines 0 comments Download
M tools/perf_expectations/perf_expectations.json View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cmp
9 years, 8 months ago (2011-04-25 22:51:11 UTC) #1
nsylvain
LGTM
9 years, 8 months ago (2011-04-25 22:59:36 UTC) #2
cmp
Patch updated, PT another L.
9 years, 8 months ago (2011-04-25 23:21:13 UTC) #3
nsylvain
9 years, 8 months ago (2011-04-25 23:29:01 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698