crypto/signature_verifier_mac.cc - Issue 6880166: Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/signature_verifier_mac.cc

Issue 6880166: Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/ (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Static casting to DWORD to fix type mismatch Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: crypto/signature_verifier_mac.cc

diff --git a/crypto/signature_verifier_mac.cc b/crypto/signature_verifier_mac.cc

index 33cdfcf4b6bbf1df88283fd77fa09e2cc2accb21..d4427205c2053b579f884f5312ff206dd393f341 100644

--- a/crypto/signature_verifier_mac.cc

+++ b/crypto/signature_verifier_mac.cc

@@ -74,7 +74,7 @@ void SignatureVerifier::VerifyUpdate(const uint8* data_part,

data.Data = const_cast<uint8*>(data_part);

data.Length = data_part_len;

CSSM_RETURN crtn = CSSM_VerifyDataUpdate(sig_handle_, &data, 1);

- DCHECK(crtn == CSSM_OK);

+ DCHECK_EQ(CSSM_OK, crtn);

}

bool SignatureVerifier::VerifyFinal() {

@@ -92,7 +92,7 @@ void SignatureVerifier::Reset() {

CSSM_RETURN crtn;

if (sig_handle_) {

crtn = CSSM_DeleteContext(sig_handle_);

- DCHECK(crtn == CSSM_OK);

+ DCHECK_EQ(CSSM_OK, crtn);

sig_handle_ = 0;

}

signature_.clear();

« no previous file with comments | « crypto/signature_creator_mac.cc ('k') | crypto/signature_verifier_nss.cc » ('j') | no next file with comments »