crypto/signature_verifier_win.cc - Issue 6880166: Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/signature_verifier_win.cc

Issue 6880166: Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/ (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Separating out DCHECK()s into their respective use-cases Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: crypto/signature_verifier_win.cc

diff --git a/crypto/signature_verifier_win.cc b/crypto/signature_verifier_win.cc

index 8bf094f1bdfff3404341e2069aba6802e196cf96..d3d4cb29d0cd37b4faa449fb47ab9c97b2ecbc6b 100644

--- a/crypto/signature_verifier_win.cc

+++ b/crypto/signature_verifier_win.cc

@@ -90,7 +90,7 @@ bool SignatureVerifier::VerifyInit(const uint8* signature_algorithm,

else if (!strcmp(signature_algorithm_id->pszObjId, szOID_RSA_MD5RSA))

hash_alg_id = CALG_MD5;

free(signature_algorithm_id);

- DCHECK(hash_alg_id != CALG_MD4);

+ DCHECK_NE(CALG_MD4, hash_alg_id);

if (hash_alg_id == CALG_MD4)

return false; // Unsupported hash algorithm.

} else if (GetLastError() == ERROR_FILE_NOT_FOUND) {

« no previous file with comments | « crypto/signature_verifier_nss.cc ('k') | ipc/ipc_channel_win.cc » ('j') | ipc/ipc_sync_message_unittest.cc » ('J')