Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/

ipc/ipc_sync_message_unittest.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Unit test to make sure that the serialization of synchronous IPC messages
 // works.  This ensures that the macros and templates were defined correctly.
 // Doesn't test the IPC channel mechanism.
 
 #include <string.h>
 
 #include "base/basictypes.h"
@@ skipping 19 matching lines @@
     *out2 = 2;
   }
 
   void On_0_3(bool* out1, int* out2, std::string* out3) {
     *out1 = false;
     *out2 = 3;
     *out3 = "0_3";
   }
 
   void On_1_1(int in1, bool* out1) {
-    DCHECK(in1 == 1);
+    DCHECK_EQ(1, in1);
     *out1 = true;
   }
 
   void On_1_2(bool in1, bool* out1, int* out2) {
     DCHECK(!in1);
     *out1 = true;
     *out2 = 12;
   }
 
   void On_1_3(int in1, std::string* out1, int* out2, bool* out3) {
-    DCHECK(in1 == 3);
+    DCHECK_EQ(3, in1);
     *out1 = "1_3";
     *out2 = 13;
     *out3 = false;
   }
 
   void On_2_1(int in1, bool in2, bool* out1) {
     DCHECK(in1 == 1 && !in2);

[Peter Kasting, 2011/04/25 19:59:15]

Nit: While you're here, you might want to break these sorts of statements into
multiple DCHECKs, one per condition.

[KushalP, 2011/04/25 20:10:06]

Should I am to do that wherever I see it? This is a pretty common usage pattern
for DCHECK that I've spotted and I wasn't sure whether the combination was
specific or not.

     *out1 = true;
   }
 
   void On_2_2(bool in1, int in2, bool* out1, int* out2) {
     DCHECK(!in1 && in2 == 2);
     *out1 = true;
     *out2 = 22;
   }
 
   void On_2_3(int in1, bool in2, std::string* out1, int* out2, bool* out3) {
@@ skipping 17 matching lines @@
   void On_3_3(int in1, std::string in2, bool in3, std::string* out1, int* out2,
               bool* out3) {
     DCHECK(in1 == 3 && in2 == "3_3" && in3);
     *out1 = "3_3";
     *out2 = 33;
     *out3 = false;
   }
 
   void On_3_4(bool in1, int in2, std::string in3, int* out1, bool* out2,
               std::string* out3, bool* out4) {
-    DCHECK(in1  && in2 == 3 && in3 == "3_4");
+    DCHECK(in1 && in2 == 3 && in3 == "3_4");
     *out1 = 34;
     *out2 = true;
     *out3 = "3_4";
     *out4 = false;
   }
 
   bool Send(IPC::Message* message) {
     // gets the reply message, stash in global
     DCHECK(g_reply == NULL);
     g_reply = message;
@@ skipping 148 matching lines @@
   DCHECK(bool1);
 
   bool1 = false;
   Send(new Msg_R_3_2(0, "3_2", false, 2, &bool1, &int1));
   DCHECK(bool1 && int1 == 32);
 
   bool1 = true;
   Send(new Msg_R_3_3(0, 3, "3_3", true, &string1, &int1, &bool1));
   DCHECK(string1 == "3_3" && int1 == 33 && !bool1);
 }