Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/

crypto/signature_verifier_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/signature_verifier.h"
 
 #include "base/logging.h"
 
 #pragma comment(lib, "crypt32.lib")
 
@@ skipping 72 matching lines @@
   DCHECK(ok || GetLastError() == ERROR_FILE_NOT_FOUND);
   ALG_ID hash_alg_id;
   if (ok) {
     hash_alg_id = CALG_MD4;  // Initialize to a weak hash algorithm that we
                              // don't support.
     if (!strcmp(signature_algorithm_id->pszObjId, szOID_RSA_SHA1RSA))
       hash_alg_id = CALG_SHA1;
     else if (!strcmp(signature_algorithm_id->pszObjId, szOID_RSA_MD5RSA))
       hash_alg_id = CALG_MD5;
     free(signature_algorithm_id);
-    DCHECK(hash_alg_id != CALG_MD4);
+    DCHECK_NE(static_cast<ALG_ID>(CALG_MD4), hash_alg_id);
     if (hash_alg_id == CALG_MD4)
       return false;  // Unsupported hash algorithm.
   } else if (GetLastError() == ERROR_FILE_NOT_FOUND) {
     // TODO(wtc): X509_ALGORITHM_IDENTIFIER isn't supported on XP SP2.  We
     // may be able to encapsulate signature_algorithm in a dummy SignedContent
     // and decode it with X509_CERT into a CERT_SIGNED_CONTENT_INFO.  For now,
     // just hardcode the hash algorithm to be SHA-1.
     hash_alg_id = CALG_SHA1;
   } else {
     return false;
@@ skipping 21 matching lines @@
 }
 
 void SignatureVerifier::Reset() {
   hash_object_.reset();
   public_key_.reset();
   signature_.clear();
 }
 
 }  // namespace crypto