Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/

crypto/cssm_init.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/cssm_init.h"
 
 #include <Security/SecBase.h>
 
 #include "base/logging.h"
 #include "base/mac/scoped_cftyperef.h"
@@ skipping 81 matching lines @@
       CSSMMalloc,
       CSSMFree,
       CSSMRealloc,
       CSSMCalloc,
       NULL
     };
 
     crtn = CSSM_ModuleAttach(&gGuidAppleCSP, &version, &cssmMemoryFunctions, 0,
                              CSSM_SERVICE_CSP, 0, CSSM_KEY_HIERARCHY_NONE,
                              NULL, 0, NULL, &csp_handle_);
-    DCHECK(crtn == CSSM_OK);
+    DCHECK_EQ(CSSM_OK, crtn);
     crtn = CSSM_ModuleAttach(&gGuidAppleX509CL, &version, &cssmMemoryFunctions,
                              0, CSSM_SERVICE_CL, 0, CSSM_KEY_HIERARCHY_NONE,
                              NULL, 0, NULL, &cl_handle_);
-    DCHECK(crtn == CSSM_OK);
+    DCHECK_EQ(CSSM_OK, crtn);
     crtn = CSSM_ModuleAttach(&gGuidAppleX509TP, &version, &cssmMemoryFunctions,
                              0, CSSM_SERVICE_TP, 0, CSSM_KEY_HIERARCHY_NONE,
                              NULL, 0, NULL, &tp_handle_);
-    DCHECK(crtn == CSSM_OK);
+    DCHECK_EQ(CSSM_OK, crtn);
   }
 
   ~CSSMInitSingleton() {
     CSSM_RETURN crtn;
     if (csp_handle_) {
       CSSM_RETURN crtn = CSSM_ModuleDetach(csp_handle_);
-      DCHECK(crtn == CSSM_OK);
+      DCHECK_EQ(CSSM_OK, crtn);
     }
     if (cl_handle_) {
       CSSM_RETURN crtn = CSSM_ModuleDetach(cl_handle_);
-      DCHECK(crtn == CSSM_OK);
+      DCHECK_EQ(CSSM_OK, crtn);
     }
     if (tp_handle_) {
       CSSM_RETURN crtn = CSSM_ModuleDetach(tp_handle_);
-      DCHECK(crtn == CSSM_OK);
+      DCHECK_EQ(CSSM_OK, crtn);
     }
     if (csp_loaded_) {
       crtn = CSSM_ModuleUnload(&gGuidAppleCSP, NULL, NULL);
-      DCHECK(crtn == CSSM_OK);
+      DCHECK_EQ(CSSM_OK, crtn);
     }
     if (cl_loaded_) {
       crtn = CSSM_ModuleUnload(&gGuidAppleX509CL, NULL, NULL);
-      DCHECK(crtn == CSSM_OK);
+      DCHECK_EQ(CSSM_OK, crtn);
     }
     if (tp_loaded_) {
       crtn = CSSM_ModuleUnload(&gGuidAppleX509TP, NULL, NULL);
-      DCHECK(crtn == CSSM_OK);
+      DCHECK_EQ(CSSM_OK, crtn);
     }
     if (inited_) {
       crtn = CSSM_Terminate();
-      DCHECK(crtn == CSSM_OK);
+      DCHECK_EQ(CSSM_OK, crtn);
     }
   }
 
   bool inited_;  // True if CSSM_Init has been called successfully.
   bool csp_loaded_;  // True if gGuidAppleCSP has been loaded
   bool cl_loaded_;  // True if gGuidAppleX509CL has been loaded.
   bool tp_loaded_;  // True if gGuidAppleX509TP has been loaded.
   CSSM_CSP_HANDLE csp_handle_;
   CSSM_CL_HANDLE cl_handle_;
   CSSM_TP_HANDLE tp_handle_;
@@ skipping 43 matching lines @@
 }
 
 ScopedCSSMData::~ScopedCSSMData() {
   if (data_.Data) {
     CSSMFree(data_.Data);
     data_.Data = NULL;
   }
 }
 
 }  // namespace crypto