Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/

app/win/iat_patch_function.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/win/iat_patch_function.h"
 
 #include "base/logging.h"
 #include "base/win/pe_image.h"
 
 namespace app {
 namespace win {
@@ skipping 196 matching lines @@
 IATPatchFunction::IATPatchFunction()
     : module_handle_(NULL),
       original_function_(NULL),
       iat_thunk_(NULL),
       intercept_function_(NULL) {
 }
 
 IATPatchFunction::~IATPatchFunction() {
   if (NULL != intercept_function_) {
     DWORD error = Unpatch();
-    DCHECK(error == NO_ERROR);
+    DCHECK_EQ(static_cast<DWORD>(NO_ERROR), error);
   }
 }
 
 DWORD IATPatchFunction::Patch(const wchar_t* module,
                               const char* imported_from_module,
                               const char* function_name,
                               void* new_function) {
   DCHECK_EQ(static_cast<void*>(NULL), original_function_);
   DCHECK_EQ(static_cast<IMAGE_THUNK_DATA*>(NULL), iat_thunk_);
   DCHECK_EQ(static_cast<void*>(NULL), intercept_function_);
@@ skipping 20 matching lines @@
     FreeLibrary(module_handle);
   }
 
   return error;
 }
 
 DWORD IATPatchFunction::Unpatch() {
   DWORD error = RestoreImportedFunction(intercept_function_,
                                         original_function_,
                                         iat_thunk_);
-  DCHECK(NO_ERROR == error);
+  DCHECK_EQ(static_cast<DWORD>(NO_ERROR), error);
 
   // Hands off the intercept if we fail to unpatch.
   // If IATPatchFunction::Unpatch fails during RestoreImportedFunction
   // it means that we cannot safely unpatch the import address table
   // patch. In this case its better to be hands off the intercept as
   // trying to unpatch again in the destructor of IATPatchFunction is
   // not going to be any safer
   if (module_handle_)
     FreeLibrary(module_handle_);
   module_handle_ = NULL;
   intercept_function_ = NULL;
   original_function_ = NULL;
   iat_thunk_ = NULL;
 
   return error;
 }
 
 }  // namespace win
 }  // namespace app