Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 6880115: Add post_processing code to update copyright year automatically. (Closed)

Created:
9 years, 8 months ago by M-A Ruel
Modified:
6 years, 9 months ago
Reviewers:
Dirk Pranke, wfa511com
CC:
chromium-reviews, Nicolas Sylvain, Peter Mayo (wrong one)
Visibility:
Public.

Description

Add post processing code to update copyright year automatically. This simplifies contributor's life by not having to do this kind of bureaucracy. Update pending_manager_test.py to be more forward compatible. TEST=lots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82588

Patch Set 1 #

Total comments: 1

Patch Set 2 : Significantly simplify code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -25 lines) Patch
M pending_manager.py View 3 chunks +9 lines, -5 lines 0 comments Download
A post_processors/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A post_processors/chromium_copyright.py View 1 1 chunk +40 lines, -0 lines 0 comments Download
M projects.py View 1 4 chunks +10 lines, -3 lines 0 comments Download
A tests/chromium_copyright_test.py View 1 1 chunk +105 lines, -0 lines 0 comments Download
M tests/pending_manager_test.py View 7 chunks +25 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
Depends on http://codereview.chromium.org/6891003/
9 years, 8 months ago (2011-04-21 19:37:36 UTC) #1
Dirk Pranke
This feels like a lot of scaffolding to implement what is essentially one ~20-line function ...
9 years, 8 months ago (2011-04-21 20:26:13 UTC) #2
M-A Ruel
I went a bit berserk when writing the unit test until I found out I ...
9 years, 8 months ago (2011-04-21 20:51:05 UTC) #3
Dirk Pranke
LGTM. Much easier to follow. Thanks!
9 years, 8 months ago (2011-04-21 21:55:57 UTC) #4
wfa511com
6 years, 9 months ago (2014-03-03 02:30:33 UTC) #5
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698