Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 6880077: AU: Handle firmware update failure when booted from FW slot B. (Closed)

Created:
9 years, 8 months ago by adlr
Modified:
9 years ago
Reviewers:
thieule
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Visibility:
Public.

Description

AU: Handle firmware update failure when booted from FW slot B. The firmware updater will fail if we are booted into FW slot B and we try to update firmware. We shouldn't treat this like a usual update failure because trying again won't help until we reboot. Thus, with this CL, we detect this case and request a reboot from the user. Technically this request is a lie, b/c we are reusing the reboot request mechanism which tells the user an update has been applied and thus must be rebooted. We accept this fib since this situation is very rare: use would have to have 2 FW update updates in a row w/o any extra boots between. Also, fix error code in subprocess. Also, remove execute permissions on a bunch of source files. BUG=chromium-os:14343 TEST=unittests, tested updates on machine that success, fail, have FW B failure Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c1d5c93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -9 lines) Patch
M action_processor.h View 1 chunk +1 line, -0 lines 0 comments Download
A decompressing_file_writer.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A delta_performer_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A extent_mapper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A extent_mapper.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A extent_ranges.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A extent_ranges_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A filesystem_copier_action.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A http_fetcher.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A main.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A omaha_request_action_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M postinstall_runner_action.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M postinstall_runner_action_unittest.cc View 4 chunks +18 lines, -11 lines 0 comments Download
M subprocess.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M update_attempter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M update_attempter.cc View 5 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
adlr
it's not as bad as it looks. Most files' changes are just removing exec perms ...
9 years, 8 months ago (2011-04-20 20:07:57 UTC) #1
thieule
9 years, 8 months ago (2011-04-21 00:13:51 UTC) #2
LGTM

On 2011/04/20 20:07:57, adlr wrote:
> it's not as bad as it looks. Most files' changes are just removing exec perms
> from the file.

Powered by Google App Engine
This is Rietveld 408576698