Issue 6880007: Use movaps instead of movsd in the gap resolver on ia32 as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6880007: Use movaps instead of movsd in the gap resolver on ia32 as well. (Closed)

Created:
9 years, 8 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Use movaps instead of movsd in the gap resolver on ia32 as well. This is ok since we don't care about preserving the upper half of xmm registers in Crankshaft code. Committed: http://code.google.com/p/v8/source/detail?r=7660

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
	M	src/ia32/lithium-gap-resolver-ia32.cc	View	1 2	2 chunks	+18 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/6880007/diff/4001/src/ia32/lithium-gap-resolver-ia32.cc File src/ia32/lithium-gap-resolver-ia32.cc (right): http://codereview.chromium.org/6880007/diff/4001/src/ia32/lithium-gap-resolver-ia32.cc#newcode318 src/ia32/lithium-gap-resolver-ia32.cc:318: } else { To fit the rest of ...

9 years, 8 months ago (2011-04-18 14:02:59 UTC) #2

fschneider

9 years, 8 months ago (2011-04-19 09:16:24 UTC) #3

http://codereview.chromium.org/6880007/diff/4001/src/ia32/lithium-gap-resolve...
File src/ia32/lithium-gap-resolver-ia32.cc (right):

http://codereview.chromium.org/6880007/diff/4001/src/ia32/lithium-gap-resolve...
src/ia32/lithium-gap-resolver-ia32.cc:318: } else {
On 2011/04/18 14:02:59, Kevin Millikin wrote:
> To fit the rest of the code, you should turn the ASSERT with the disjunction
> above into ASSERT(destination->IsDoubleRegister()) in the else branch.  Also,
> the other code seems to always handle the register case first.

Done.

Expand Messages | Collapse Messages