Fix print preview clipping issues due to scaling.

Fix print preview clipping issues due to scaling.

BUG=79941
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83657

[Chris Guillory, 2011-04-20 23:42:12]

Proposal.

[vandebo (ex-Chrome), 2011-04-25 22:11:47]

It looks like this CL is incomplete, right?  I concentrated on the interface
changes.

http://codereview.chromium.org/6879098/diff/6001/printing/metafile.h
File printing/metafile.h (right):

http://codereview.chromium.org/6879098/diff/6001/printing/metafile.h#newcode61
printing/metafile.h:61: const gfx::Size& content_size,
Instead of content_size and content_origin, we should just have gfx::Rect
content_area.

http://codereview.chromium.org/6879098/diff/6001/printing/metafile.h#newcode69
printing/metafile.h:69: const gfx::Point& content_origin,
StartPage and StartPageForVectorCanvas should have the same interface.

http://codereview.chromium.org/6879098/diff/6001/printing/pdf_metafile_skia.h
File printing/pdf_metafile_skia.h (right):

http://codereview.chromium.org/6879098/diff/6001/printing/pdf_metafile_skia.h...
printing/pdf_metafile_skia.h:70: #endif  // PRINTING_PDF_METAFILE_SKIA_H_
thanks

http://codereview.chromium.org/6879098/diff/6001/skia/ext/vector_platform_dev...
File skia/ext/vector_platform_device_skia.h (right):

http://codereview.chromium.org/6879098/diff/6001/skia/ext/vector_platform_dev...
skia/ext/vector_platform_device_skia.h:35: const SkMatrix& initialTransform);
I don't think we need the initialTransform beyond the device creation?

[Chris Guillory, 2011-04-25 23:47:08]

On 2011/04/25 22:11:47, vandebo wrote:
> It looks like this CL is incomplete, right?  I concentrated on the interface
Yes need:
1. Propagate interface changes to other platforms. Done.
2. http://codereview.appspot.com/4435074/

[Chris Guillory, 2011-04-25 23:47:12]

http://codereview.chromium.org/6879098/diff/6001/printing/metafile.h
File printing/metafile.h (right):

http://codereview.chromium.org/6879098/diff/6001/printing/metafile.h#newcode61
printing/metafile.h:61: const gfx::Size& content_size,
On 2011/04/25 22:11:47, vandebo wrote:
> Instead of content_size and content_origin, we should just have gfx::Rect
> content_area.

Done.

http://codereview.chromium.org/6879098/diff/6001/printing/metafile.h#newcode69
printing/metafile.h:69: const gfx::Point& content_origin,
On 2011/04/25 22:11:47, vandebo wrote:
> StartPage and StartPageForVectorCanvas should have the same interface.

Done.

http://codereview.chromium.org/6879098/diff/6001/printing/pdf_metafile_skia.h
File printing/pdf_metafile_skia.h (right):

http://codereview.chromium.org/6879098/diff/6001/printing/pdf_metafile_skia.h...
printing/pdf_metafile_skia.h:70: #endif  // PRINTING_PDF_METAFILE_SKIA_H_
On 2011/04/25 22:11:47, vandebo wrote:
> thanks
Np.

http://codereview.chromium.org/6879098/diff/6001/skia/ext/vector_platform_dev...
File skia/ext/vector_platform_device_skia.h (right):

http://codereview.chromium.org/6879098/diff/6001/skia/ext/vector_platform_dev...
skia/ext/vector_platform_device_skia.h:35: const SkMatrix& initialTransform);
On 2011/04/25 22:11:47, vandebo wrote:
> I don't think we need the initialTransform beyond the device creation?
Correct. Done.

[vandebo (ex-Chrome), 2011-04-26 02:42:30]

LG after a quick look.  But as we discussed you want to change the content area
from integers to floats.

[Chris Guillory, 2011-04-27 03:03:43]

On 2011/04/26 02:42:30, vandebo wrote:
> LG after a quick look.  But as we discussed you want to change the content
area
> from integers to floats.
Keeping content area as integers for now.

[vandebo (ex-Chrome), 2011-04-27 22:11:34]

LGTM with one comment.

http://codereview.chromium.org/6879098/diff/6010/printing/pdf_metafile_skia.cc
File printing/pdf_metafile_skia.cc (right):

http://codereview.chromium.org/6879098/diff/6010/printing/pdf_metafile_skia.c...
printing/pdf_metafile_skia.cc:52: SkRefPtr<SkPDFDevice> pdf_device =
This could be quiet a bit cleaner with a few variables.

[Chris Guillory, 2011-04-29 18:25:44]

http://codereview.chromium.org/6879098/diff/6010/printing/pdf_metafile_skia.cc
File printing/pdf_metafile_skia.cc (right):

http://codereview.chromium.org/6879098/diff/6010/printing/pdf_metafile_skia.c...
printing/pdf_metafile_skia.cc:52: SkRefPtr<SkPDFDevice> pdf_device =
On 2011/04/27 22:11:34, vandebo wrote:
> This could be quiet a bit cleaner with a few variables.

Done.

[vandebo (ex-Chrome), 2011-04-29 18:30:14]

LG

[Chris Guillory, 2011-04-29 18:43:39]

Adding skia deps roll.

[reed1, 2011-04-29 18:55:28]

LGTM