third_party/apple_apsl/README.chromium - Issue 6879095: Address post-review feedback for r81702

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/apple_apsl/README.chromium

Issue 6879095: Address post-review feedback for r81702 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 Name: Darwin	1 Name: Darwin

2 URL: http://www.opensource.apple.com/	2 URL: http://www.opensource.apple.com/

3 Version: unknown	3 Version: unknown

4 Security Critical: yes	4 Security Critical: yes

5	5

6 Four files are excerpted here:	6 Four files are excerpted here:

7	7

8 malloc.h from:	8 malloc.h from:

9 http://www.opensource.apple.com/source/Libc/Libc-583/include/malloc/malloc.h	9 http://www.opensource.apple.com/source/Libc/Libc-583/include/malloc/malloc.h

10	10

(...skipping 20 matching lines...) Expand all Loading...
31 - Added an #include of the CFRuntime.h file.	31 - Added an #include of the CFRuntime.h file.

32 - Removed everything but the definition of __CFAllocator.	32 - Removed everything but the definition of __CFAllocator.

33 - Modified the reference of CFRuntimeBase to ChromeCFRuntimeBase.	33 - Modified the reference of CFRuntimeBase to ChromeCFRuntimeBase.

34 - Renamed __CFAllocator to ChromeCFAllocator9and10 to avoid possible name	34 - Renamed __CFAllocator to ChromeCFAllocator9and10 to avoid possible name

35 conflicts.	35 conflicts.

36 - Added a presumed definition of ChromeCFAllocator11.	36 - Added a presumed definition of ChromeCFAllocator11.

37	37

38 cssmapplePriv.h from:	38 cssmapplePriv.h from:

39 http://www.opensource.apple.com/source/libsecurity_cssm/libsecurity_cssm-31536/l ib/cssmapplePriv.h	39 http://www.opensource.apple.com/source/libsecurity_cssm/libsecurity_cssm-31536/l ib/cssmapplePriv.h

40	40

	41 Warning: Technically, this is a private Apple header, and as such provides no

	42 guarantee for forwards compatibility. However, the use of this header is the
	wtc 2011/04/20 23:28:11 Nit: forwards compatibility => backwards compatibi Nit: forwards compatibility => backwards compatibility ? Or just say "API stability"?
	43 only way to implement OCSP checking per Apple's public documentation on the

	44 usage of their Trust Policy Module. Further, the use of this private header

	45 is the recommended approach from Apple for modifying OCSP policies.

	46

	47 See: http://developer.apple.com/documentation/Security/Reference/SecAppleTrustPo licyModuleSpec/Apple_Trust_Policy_Module_Functional_Specification.pdf

	48 and http://lists.apple.com/archives/apple-cdsa/2008/Aug/msg00008.html

	49

41 Modifications:	50 Modifications:

42 - Removed unneeded definitions for internal Apple CSP DL enums and structs	51 - Removed unneeded definitions for internal Apple CSP DL enums and structs

43 - Added a comment explaining its usage

OLD	NEW

« net/base/x509_certificate_mac.cc ('K') | « net/base/x509_certificate_mac.cc ('k') | third_party/apple_apsl/cssmapplePriv.h » ('j') | no next file with comments »