Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/extension_manifests_unittest.cc

Issue 6879077: Make sure that extensions can launch web urls with web safe schemes only. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/test/data/extensions/manifest_tests/launch_url_invalid_type.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_manifests_unittest.cc
===================================================================
--- chrome/common/extensions/extension_manifests_unittest.cc (revision 82260)
+++ chrome/common/extensions/extension_manifests_unittest.cc (working copy)
@@ -256,8 +256,12 @@
errors::kInvalidLaunchLocalPath);
LoadAndExpectError("launch_path_invalid_value.json",
errors::kInvalidLaunchLocalPath);
- LoadAndExpectError("launch_url_invalid_type.json",
+ LoadAndExpectError("launch_url_invalid_type_1.json",
errors::kInvalidLaunchWebURL);
+ LoadAndExpectError("launch_url_invalid_type_2.json",
+ errors::kInvalidLaunchWebURL);
+ LoadAndExpectError("launch_url_invalid_type_3.json",
+ errors::kInvalidLaunchWebURL);
scoped_refptr<Extension> extension;
extension = LoadAndExpectSuccess("launch_local_path.json");
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/test/data/extensions/manifest_tests/launch_url_invalid_type.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698