Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 6879031: Add optional creation to ProfileKeyedServiceFactory. (Closed)

Created:
9 years, 8 months ago by Torne
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add optional creation to ProfileKeyedServiceFactory. Add an extra parameter to ProfileKeyedServiceFactory::GetServiceForProfile so that individual service factories can choose whether the service should be created if it doesn't exist. BUG=77155 TEST=existing tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82282

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add docs for new parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M chrome/browser/background_contents_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background_mode_manager_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_keyed_service_factory.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_keyed_service_factory.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/tabs/pinned_tab_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Torne
Some of the services are going to need this because callers expect to be able ...
9 years, 8 months ago (2011-04-19 14:54:30 UTC) #1
Miranda Callahan
LGTM with comment nit. http://codereview.chromium.org/6879031/diff/1/chrome/browser/profiles/profile_keyed_service_factory.h File chrome/browser/profiles/profile_keyed_service_factory.h (right): http://codereview.chromium.org/6879031/diff/1/chrome/browser/profiles/profile_keyed_service_factory.h#newcode57 chrome/browser/profiles/profile_keyed_service_factory.h:57: ProfileKeyedService* GetServiceForProfile(Profile* profile, bool create); ...
9 years, 8 months ago (2011-04-19 17:04:20 UTC) #2
Torne
http://codereview.chromium.org/6879031/diff/1/chrome/browser/profiles/profile_keyed_service_factory.h File chrome/browser/profiles/profile_keyed_service_factory.h (right): http://codereview.chromium.org/6879031/diff/1/chrome/browser/profiles/profile_keyed_service_factory.h#newcode57 chrome/browser/profiles/profile_keyed_service_factory.h:57: ProfileKeyedService* GetServiceForProfile(Profile* profile, bool create); On 2011/04/19 17:04:20, Miranda ...
9 years, 8 months ago (2011-04-19 17:15:13 UTC) #3
commit-bot: I haz the power
9 years, 8 months ago (2011-04-20 10:57:21 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698