Support Float64Arrays

src/x64/lithium-codegen-x64.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2332 matching lines @@
 
 void LCodeGen::DoLoadKeyedSpecializedArrayElement(
     LLoadKeyedSpecializedArrayElement* instr) {
   Register external_pointer = ToRegister(instr->external_pointer());
   Register key = ToRegister(instr->key());
   ExternalArrayType array_type = instr->array_type();
   if (array_type == kExternalFloatArray) {
     XMMRegister result(ToDoubleRegister(instr->result()));
     __ movss(result, Operand(external_pointer, key, times_4, 0));
     __ cvtss2sd(result, result);
+  } else if (array_type == kExternalDoubleArray) {
+    __ movsd(ToDoubleRegister(instr->result()),
+             Operand(external_pointer,  key, times_8, 0));

[danno, 2011/04/18 16:36:28]

remove extra space before key

[Jakob Kummerow, 2011/04/20 15:01:13]

Done.

   } else {
     Register result(ToRegister(instr->result()));
     switch (array_type) {
       case kExternalByteArray:
         __ movsxbq(result, Operand(external_pointer, key, times_1, 0));
         break;
       case kExternalUnsignedByteArray:
       case kExternalPixelArray:
         __ movzxbq(result, Operand(external_pointer, key, times_1, 0));
         break;
       case kExternalShortArray:
         __ movsxwq(result, Operand(external_pointer, key, times_2, 0));
         break;
       case kExternalUnsignedShortArray:
         __ movzxwq(result, Operand(external_pointer, key, times_2, 0));
         break;
       case kExternalIntArray:
         __ movsxlq(result, Operand(external_pointer, key, times_4, 0));
         break;
       case kExternalUnsignedIntArray:
         __ movl(result, Operand(external_pointer, key, times_4, 0));
         __ testl(result, result);
         // TODO(danno): we could be more clever here, perhaps having a special
         // version of the stub that detects if the overflow case actually
         // happens, and generate code that returns a double rather than int.
         DeoptimizeIf(negative, instr->environment());
         break;
       case kExternalFloatArray:
+      case kExternalDoubleArray:
         UNREACHABLE();
         break;
     }
   }
 }
 
 
 void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric* instr) {
   ASSERT(ToRegister(instr->object()).is(rdx));
   ASSERT(ToRegister(instr->key()).is(rax));
@@ skipping 639 matching lines @@
 
 void LCodeGen::DoStoreKeyedSpecializedArrayElement(
     LStoreKeyedSpecializedArrayElement* instr) {
   Register external_pointer = ToRegister(instr->external_pointer());
   Register key = ToRegister(instr->key());
   ExternalArrayType array_type = instr->array_type();
   if (array_type == kExternalFloatArray) {
     XMMRegister value(ToDoubleRegister(instr->value()));
     __ cvtsd2ss(value, value);
     __ movss(Operand(external_pointer, key, times_4, 0), value);
+  } else if (array_type == kExternalDoubleArray) {
+    __ movsd(Operand(external_pointer,  key, times_8, 0),

[danno, 2011/04/18 16:36:28]

remove extra space before key

[Jakob Kummerow, 2011/04/20 15:01:13]

Done.

+             ToDoubleRegister(instr->value()));
   } else {
     Register value(ToRegister(instr->value()));
     switch (array_type) {
       case kExternalPixelArray:
         {  // Clamp the value to [0..255].
           NearLabel done;
           __ testl(value, Immediate(0xFFFFFF00));
           __ j(zero, &done);
           __ setcc(negative, value);  // 1 if negative, 0 if positive.
           __ decb(value);  // 0 if negative, 255 if positive.
           __ bind(&done);
           __ movb(Operand(external_pointer, key, times_1, 0), value);
         }
         break;
       case kExternalByteArray:
       case kExternalUnsignedByteArray:
         __ movb(Operand(external_pointer, key, times_1, 0), value);
         break;
       case kExternalShortArray:
       case kExternalUnsignedShortArray:
         __ movw(Operand(external_pointer, key, times_2, 0), value);
         break;
       case kExternalIntArray:
       case kExternalUnsignedIntArray:
         __ movl(Operand(external_pointer, key, times_4, 0), value);
         break;
       case kExternalFloatArray:
+      case kExternalDoubleArray:
         UNREACHABLE();
         break;
     }
   }
 }
 
 
 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) {
   if (instr->length()->IsRegister()) {
     __ cmpq(ToRegister(instr->index()), ToRegister(instr->length()));
@@ skipping 939 matching lines @@
   RegisterEnvironmentForDeoptimization(environment);
   ASSERT(osr_pc_offset_ == -1);
   osr_pc_offset_ = masm()->pc_offset();
 }
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_X64