Issue 6879006: Disable the context menu on the keyboard overlay and the print dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6879006: Disable the context menu on the keyboard overlay and the print dialog. (Closed)

Created:
9 years, 8 months ago by mazda

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, Scott Byer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disable the context menu on the keyboard overlay and the print dialog. This change fixes the crash bug which happens when right-clicking the keyboard overlay or the print dialog. BUG=chromium-os:14147 TEST=manually on the chrome notebook Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82048

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -0 lines)			Patch
M	chrome/browser/printing/print_dialog_cloud.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/printing/print_dialog_cloud_internal.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/keyboard_overlay_delegate.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/keyboard_overlay_delegate.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 82048

Expand Messages | Collapse Messages