Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2574)

Unified Diff: base/i18n/rtl.h

Issue 6878089: Add and use a base::i18n::StringWithDirection for carrying titles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/i18n/rtl.h
diff --git a/base/i18n/rtl.h b/base/i18n/rtl.h
index a75ed4f967bcd20bd42048994bf5114d51825917..bca4d3bad4c625bf352b8c244410ac73ac71ca22 100644
--- a/base/i18n/rtl.h
+++ b/base/i18n/rtl.h
@@ -31,6 +31,19 @@ enum TextDirection {
LEFT_TO_RIGHT,
};
+// A string along with the text direction it should be displayed in.
+// Conceptually this is a struct; we just use 'class' to make it easier for
+// others to forward-declare us with 'class StringWithDirection'.
+class StringWithDirection {
darin (slow to review) 2011/04/21 02:56:00 String16WithDirection maybe? see NullableString16
+public:
+ StringWithDirection() : direction(UNKNOWN_DIRECTION) { }
+ StringWithDirection(const string16& str, TextDirection dir)
+ : string(str), direction(dir) { }
+
+ string16 string;
darin (slow to review) 2011/04/21 02:56:00 do you need to mutate these later? how about just
+ TextDirection direction;
+};
+
// Get the locale that the currently running process has been configured to use.
// The return value is of the form language[-country] (e.g., en-US) where the
// language is the 2 or 3 letter code from ISO-639.
« no previous file with comments | « no previous file | chrome/browser/notifications/balloon_host.h » ('j') | chrome/browser/notifications/balloon_host.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698