Issue 6878081: Blind fix for a Linux only crash in AudioManager::Destroy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6878081: Blind fix for a Linux only crash in AudioManager::Destroy (Closed)

Created:
9 years, 8 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, Ami GONE FROM WEBRTC_CHROMIUM, scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Blind fix for a Linux only crash in AudioManager::Destroy BUG=80059 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82612

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	media/audio/audio_manager.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

looking at the code it seems impossible for g_audio_manager to be non-NULL inside Destroy does ...

9 years, 8 months ago (2011-04-21 18:17:17 UTC) #2

Lei Zhang

On 2011/04/21 18:17:17, scherkus wrote: > looking at the code it seems impossible for g_audio_manager ...

9 years, 8 months ago (2011-04-22 00:22:21 UTC) #3

scherkus (not reviewing)

crazy! alright LGTM and hopefully that fixes it :|

9 years, 8 months ago (2011-04-22 02:12:21 UTC) #4

Ami GONE FROM WEBRTC_CHROMIUM

9 years, 8 months ago (2011-04-23 21:04:45 UTC) #5

FYI

Random thoughts about the underlying bug:
- GetAudioManager can race with itself, registering multiple AtExit handlers
(and incidentally leaking audio managers).  The second AtExit invocation
could cause the reported crash.
- GAM & Destroy have no common memory barriers so unless the AtExit
machinery makes such promises, it's quite possible for the observed state of
the global variables to be inconsistent.

-a

Expand Messages | Collapse Messages