subprocess2.py - Issue 6878069: Unicode input is also accepted for stdin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: subprocess2.py

Issue 6878069: Unicode input is also accepted for stdin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: subprocess2.py

diff --git a/subprocess2.py b/subprocess2.py

index 64a23a8bc1942c03196bd2b93c297101f30e3981..acfe4a9a504e40648e5a0e488da7797b4858e282 100644

--- a/subprocess2.py

+++ b/subprocess2.py

@@ -207,7 +207,7 @@ def communicate(args, timeout=None, **kwargs):

kwargs['stdin'] = open(os.devnull, 'r')

stdin = None

else:

- assert isinstance(stdin, str)

+ assert isinstance(stdin, basestring)

# When stdin is passed as an argument, use it as the actual input data and

# set the Popen() parameter accordingly.

kwargs['stdin'] = PIPE

« no previous file with comments | « no previous file | no next file » | no next file with comments »