Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 6878016: Chrome could not accept IE's proxy exclusions list delimited by commas. (Closed)

Created:
9 years, 8 months ago by Takashi Toyoshima
Modified:
9 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Chrome could not accept IE's proxy exclusions list delimited by commas. This change add comma to delimiters list. BUG=76168 TEST=net_unittests --gtest_filter=ProxyConfigServiceWinTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82041

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M net/proxy/proxy_config_service_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_win_unittest.cc View 1 2 4 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Takashi Toyoshima
Could you review this change? This is a very small one.
9 years, 8 months ago (2011-04-18 13:40:53 UTC) #1
eroman
9 years, 8 months ago (2011-04-18 23:33:35 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698