Issue 6878009: Fix x64 typefeedback for property assignments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6878009: Fix x64 typefeedback for property assignments. (Closed)

Created:
9 years, 8 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix x64 typefeedback for property assignments. There was not ast-id recorded. I removed the default arguments for the helper functions that emit IC calls to make sure we are not missing other places. Committed: http://code.google.com/p/v8/source/detail?r=7644

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -28 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	12 chunks	+12 lines, -12 lines	0 comments	Download
M	src/full-codegen.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	7 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages