Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: chrome/browser/autofill/phone_number_i18n_unittest.cc

Issue 6877130: These changes *are* for review :) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/phone_number_i18n.cc ('k') | chrome/browser/autofill/phone_number_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/phone_number_i18n_unittest.cc
===================================================================
--- chrome/browser/autofill/phone_number_i18n_unittest.cc (revision 85992)
+++ chrome/browser/autofill/phone_number_i18n_unittest.cc (working copy)
@@ -283,20 +283,29 @@
&number));
EXPECT_EQ(number, string16());
// Italian number
- EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16("39"),
- ASCIIToUTF16(""),
- ASCIIToUTF16("236618300"),
- "US",
+ EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16(""),
+ ASCIIToUTF16("347"),
+ ASCIIToUTF16("2345678"),
+ "IT",
autofill_i18n::INTERNATIONAL,
&number));
- EXPECT_EQ(number, ASCIIToUTF16("+39 236618300"));
- EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16("39"),
- ASCIIToUTF16(""),
- ASCIIToUTF16("236618300"),
- "US",
+ EXPECT_EQ(number, ASCIIToUTF16("+39 347 234 5678"));
+ // German number.
+ EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16("49"),
+ ASCIIToUTF16("024"),
+ ASCIIToUTF16("2345678901"),
+ "DE",
autofill_i18n::NATIONAL,
&number));
- EXPECT_EQ(number, ASCIIToUTF16("236618300"));
+ EXPECT_EQ(number, ASCIIToUTF16("02423/45678901"));
+
+ EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16("49"),
+ ASCIIToUTF16("024"),
+ ASCIIToUTF16("2345678901"),
+ "DE",
+ autofill_i18n::INTERNATIONAL,
+ &number));
+ EXPECT_EQ(number, ASCIIToUTF16("+49 2423/45678901"));
}
TEST(PhoneNumberI18NTest, FormatPhone) {
« no previous file with comments | « chrome/browser/autofill/phone_number_i18n.cc ('k') | chrome/browser/autofill/phone_number_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698