chrome/browser/autofill/autofill_ie_toolbar_import_win_unittest.cc - Issue 6877130: These changes *are* for review :)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_ie_toolbar_import_win_unittest.cc

Issue 6877130: These changes *are* for review :) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/autofill_ie_toolbar_import_win.cc ('k') | chrome/browser/autofill/autofill_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autofill_ie_toolbar_import_win_unittest.cc

===================================================================

--- chrome/browser/autofill/autofill_ie_toolbar_import_win_unittest.cc (revision 85992)

+++ chrome/browser/autofill/autofill_ie_toolbar_import_win_unittest.cc (working copy)

@@ -44,7 +44,7 @@

{ L"email", L"jdoe@test.com" },

{ L"company_name", L"Testcompany" },

{ L"phone_home_number", L"555-5555" },

- { L"phone_home_city_code", L"444" },

+ { L"phone_home_city_code", L"650" },

{ L"phone_home_country_code", L"1" },

};

@@ -54,8 +54,8 @@

{ L"email", L"janedoe@test.com" },

{ L"company_name", L"Testcompany" },

{ L"phone_fax_number", L"555-6666" },

- { L"phone_fax_city_code", L"777" },

- { L"phone_fax_country_code", L"2" },

+ { L"phone_fax_city_code", L"812" },

+ { L"phone_fax_country_code", L"7" },

};

ValueDescription credit_card[] = {

@@ -171,7 +171,7 @@

EXPECT_EQ(profiles[1].GetInfo(PHONE_HOME_COUNTRY_CODE), profile1[7].value);

EXPECT_EQ(profiles[1].GetInfo(PHONE_HOME_CITY_CODE), profile1[6].value);

EXPECT_EQ(profiles[1].GetInfo(PHONE_HOME_NUMBER), L"5555555");

- EXPECT_EQ(profiles[1].GetInfo(PHONE_HOME_WHOLE_NUMBER), L"14445555555");

+ EXPECT_EQ(profiles[1].GetInfo(PHONE_HOME_WHOLE_NUMBER), L"+16505555555");

EXPECT_EQ(profiles[0].GetInfo(NAME_FIRST), profile2[0].value);

EXPECT_EQ(profiles[0].GetInfo(NAME_LAST), profile2[1].value);

@@ -180,7 +180,7 @@

EXPECT_EQ(profiles[0].GetInfo(PHONE_FAX_COUNTRY_CODE), profile2[6].value);

EXPECT_EQ(profiles[0].GetInfo(PHONE_FAX_CITY_CODE), profile2[5].value);

EXPECT_EQ(profiles[0].GetInfo(PHONE_FAX_NUMBER), L"5556666");

- EXPECT_EQ(profiles[0].GetInfo(PHONE_FAX_WHOLE_NUMBER), L"27775556666");

+ EXPECT_EQ(profiles[0].GetInfo(PHONE_FAX_WHOLE_NUMBER), L"+78125556666");

ASSERT_EQ(credit_cards.size(), 1);

EXPECT_EQ(credit_cards[0].GetInfo(CREDIT_CARD_NAME), credit_card[0].value);

« no previous file with comments | « chrome/browser/autofill/autofill_ie_toolbar_import_win.cc ('k') | chrome/browser/autofill/autofill_manager_unittest.cc » ('j') | no next file with comments »