chrome/browser/autofill/phone_number_i18n_unittest.cc - Issue 6877130: These changes *are* for review :)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/phone_number_i18n_unittest.cc

Issue 6877130: These changes *are* for review :) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/phone_number_i18n.cc ('K') | « chrome/browser/autofill/phone_number_i18n.cc ('k') | chrome/browser/autofill/phone_number_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/phone_number_i18n_unittest.cc

===================================================================

--- chrome/browser/autofill/phone_number_i18n_unittest.cc (revision 85791)

+++ chrome/browser/autofill/phone_number_i18n_unittest.cc (working copy)

@@ -283,20 +283,29 @@

&number));

EXPECT_EQ(number, string16());

// Italian number

- EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16("39"),

- ASCIIToUTF16(""),

- ASCIIToUTF16("236618300"),

- "US",

+ EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16(""),

+ ASCIIToUTF16("347"),

+ ASCIIToUTF16("2345678"),

+ "IT",

autofill_i18n::INTERNATIONAL,

&number));

- EXPECT_EQ(number, ASCIIToUTF16("+39 236618300"));

- EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16("39"),

- ASCIIToUTF16(""),

- ASCIIToUTF16("236618300"),

- "US",

+ EXPECT_EQ(number, ASCIIToUTF16("+39 347 234 5678"));

+ // German number.

+ EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16("49"),

+ ASCIIToUTF16("024"),

+ ASCIIToUTF16("2345678901"),

+ "DE",

autofill_i18n::NATIONAL,

&number));

- EXPECT_EQ(number, ASCIIToUTF16("236618300"));

+ EXPECT_EQ(number, ASCIIToUTF16("02423/45678901"));

+ EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16("49"),

+ ASCIIToUTF16("024"),

+ ASCIIToUTF16("2345678901"),

+ "DE",

+ autofill_i18n::INTERNATIONAL,

+ &number));

+ EXPECT_EQ(number, ASCIIToUTF16("+49 2423/45678901"));

}

TEST(PhoneNumberI18NTest, FormatPhone) {