Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: chrome/browser/autofill/autofill_profile.h

Issue 6877130: These changes *are* for review :) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_profile.h
===================================================================
--- chrome/browser/autofill/autofill_profile.h (revision 84722)
+++ chrome/browser/autofill/autofill_profile.h (working copy)
@@ -119,6 +119,15 @@
// aid with correct aggregation of new data.
const string16 PrimaryValue() const;
+ // Normalizes the phone and numbers.
dhollowa 2011/05/13 18:55:35 nit: "Normalizes the home phone and fax numbers."
GeorgeY 2011/05/18 17:41:45 Done.
+ // Should be called after all of the form data is imported into profile.
+ // If PHONE_*_WHOLE_NUMBER is not set, then derives it from PHONE_*_CITY_CODE,
+ // PHONE_*_COUNTRY_CODE and PHONE_*_CITY_AND_NUMBER.
+ // Drops unparsable numbers, so the numbers that are incomplete or wrong
+ // are not saved. Returns true if all numbers were successfully parsed,
+ // false otherwise.
+ bool NormalizePhones();
+
// Overwrites the single-valued field data in |profile| with this
// Profile. Or, for multi-valued fields append the new values.
void OverwriteWithOrAddTo(const AutofillProfile& profile);
@@ -161,8 +170,8 @@
std::vector<NameInfo> name_;
std::vector<EmailInfo> email_;
CompanyInfo company_;
- std::vector<HomePhoneNumber> home_number_;
- std::vector<FaxNumber> fax_number_;
+ std::vector<PhoneNumber> home_number_;
+ std::vector<PhoneNumber> fax_number_;
Address address_;
};

Powered by Google App Engine
This is Rietveld 408576698