Issue 6877110: Renable platform_KernelErrorPaths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6877110: Renable platform_KernelErrorPaths. (Closed)

Created:
9 years, 8 months ago by DaleCurtis

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines, ericli

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli

Base URL:
ssh://gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

Renable platform_KernelErrorPaths. Per msb, this test can be reenabled. Change-Id: Icd6cf41e910915b26c8ce511046bfffd909d3980 BUG=none TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9a3e00f

Patch Set 1 #

Patch Set 2 : Quotes. #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	server/site_tests/suites/control.regression	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mandeep Singh Baines

9 years, 8 months ago (2011-04-21 16:08:33 UTC) #2

LGTM. Thanks!

dalecurtis@chromium.org (dalecurtis@chromium.org) wrote:
> Reviewers: Mandeep Singh Baines, ericli,
> 
> Description:
> Renable platform_KernelErrorPaths.
> 
> Per msb, this test can be reenabled.
> 
> Change-Id: Icd6cf41e910915b26c8ce511046bfffd909d3980
> 
> BUG=none
> TEST=none
> 
> 
> Please review this at http://codereview.chromium.org/6877110/
> 
> SVN Base: ssh://gitrw.chromium.org:9222/autotest.git@master
> 
> Affected files:
>   M server/site_tests/suites/control.regression
> 
> 
> Index: server/site_tests/suites/control.regression
> diff --git a/server/site_tests/suites/control.regression
> b/server/site_tests/suites/control.regression
> index
1af3f8c094af3b6df41d4f6055fe3ff1c6bb81cb..52225cbbb4c3233bfc16bf6ec1247ab01705e3e6
> 100644
> --- a/server/site_tests/suites/control.regression
> +++ b/server/site_tests/suites/control.regression
> @@ -124,10 +124,9 @@ def run_assigned_tests(machine):
>    if not client_attributes.has_resume_bug:
>      client_at.run_test('power_Resume')
> 
> -# TODO(msb): re-enable KernelErrorPaths, see http://crosbug.com/7679
> -# job.run_test("platform_KernelErrorPaths", host=client)
> +  job.run_test('platform_KernelErrorPaths', host=client)
>    if client_attributes.has_chromeos_firmware:
> -    job.run_test("logging_KernelCrashServer", host=client)
> +    job.run_test('logging_KernelCrashServer', host=client)
> 
>    # This test stops tcsd which is known to cause issues with cryptohome and
>    # possibly other services. Specifically, cros_ui_test based tests
> will fail;
> 
>

Expand Messages | Collapse Messages