Make predicates on lithium instruction classes non-virtual.

Make predicates on lithium instruction classes non-virtual.

This is the lithium analog to the refactoring of the HIR classes in r7659.
Committed: http://code.google.com/p/v8/source/detail?r=7662

[fschneider, 2011-04-19 11:06:38]

This is a similar refactoring as the one I did for the hydrogen instruction
classes.

[Kevin Millikin (Chromium), 2011-04-19 12:20:30]

LGTM.

http://codereview.chromium.org/6877036/diff/3002/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):

http://codereview.chromium.org/6877036/diff/3002/src/arm/lithium-arm.h#newcod...
src/arm/lithium-arm.h:169: virtual Opcode opcode() const { return
LInstruction::k##type; } \
Thank you.

http://codereview.chromium.org/6877036/diff/3002/src/arm/lithium-arm.h#newcod...
src/arm/lithium-arm.h:1109: virtual Opcode opcode() const { return
LInstruction::kArithmeticD; }
Maybe add a comment here and below that DECLARE_CONCRETE_INSTRUCTION doesn't
work because the mnemonic depends on the op?

[fschneider, 2011-04-19 12:31:40]

On 2011/04/19 12:20:30, Kevin Millikin wrote:
> LGTM.
> 
> http://codereview.chromium.org/6877036/diff/3002/src/arm/lithium-arm.h
> File src/arm/lithium-arm.h (right):
> 
>
http://codereview.chromium.org/6877036/diff/3002/src/arm/lithium-arm.h#newcod...
> src/arm/lithium-arm.h:169: virtual Opcode opcode() const { return
> LInstruction::k##type; } \
> Thank you.
> 
>
http://codereview.chromium.org/6877036/diff/3002/src/arm/lithium-arm.h#newcod...
> src/arm/lithium-arm.h:1109: virtual Opcode opcode() const { return
> LInstruction::kArithmeticD; }
> Maybe add a comment here and below that DECLARE_CONCRETE_INSTRUCTION doesn't
> work because the mnemonic depends on the op?

I'll replace these aggregate instructions pretty soon. They don't seem to buy us
much.