Issue 6877015: Add combine_stdout_stderr as well as make success less verbose.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6877015: Add combine_stdout_stderr as well as make success less verbose. (Closed)

Created:
9 years, 8 months ago by sosa

Modified:
9 years, 8 months ago

Reviewers:
dgarrett

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Add combine_stdout_stderr as well as make success less verbose. Change-Id: If46fd1558a00498ce4721dd756532e916f49bc19 BUG=chromium-os:12950 TEST=Ran with autestharness and ran unittests. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c894a0a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Cleanup #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	lib/cros_build_lib.py	View	1	4 chunks	+9 lines, -8 lines	0 comments	Download
	M	lib/cros_vm_lib.sh	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

Our logs are getting overly verbose. This is an effort to clean that up.

9 years, 8 months ago (2011-04-18 21:26:08 UTC) #1

dgarrett

9 years, 8 months ago (2011-04-18 23:13:20 UTC) #2

LGTM with two nits.

http://codereview.chromium.org/6877015/diff/1/lib/cros_build_lib.py
File lib/cros_build_lib.py (right):

http://codereview.chromium.org/6877015/diff/1/lib/cros_build_lib.py#newcode49
lib/cros_build_lib.py:49: combine_stdout_stderr: Combines stdout and stdin
streams into stdout.  Auto
'.  Auto' should be:
'. Auto'

http://codereview.chromium.org/6877015/diff/1/lib/cros_build_lib.py#newcode113
lib/cros_build_lib.py:113: if not error_ok:
Might as well do this...

if proc.returncode != 0 and not error_ok:

Expand Messages | Collapse Messages