Issue 6875005: Fix debuger evaluation on a breakpoint inside eval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6875005: Fix debuger evaluation on a breakpoint inside eval (Closed)

Created:
9 years, 8 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, antonm

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix debuger evaluation on a breakpoint inside eval Corresponding Chromium issue: http://code.google.com/p/chromium/issues/detail?id=74412 Committed: http://code.google.com/p/v8/source/detail?r=7633

Patch Set 2 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	src/runtime.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/mjsunit/debug-evaluate-with.js	View	1	2 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

antonm

LGTM, but let's wait for Søren http://codereview.chromium.org/6875005/diff/1/test/mjsunit/debug-evaluate-with.js File test/mjsunit/debug-evaluate-with.js (right): http://codereview.chromium.org/6875005/diff/1/test/mjsunit/debug-evaluate-with.js#newcode51 test/mjsunit/debug-evaluate-with.js:51: print(exec_state.frame(0).evaluate('foo').value()); print?

9 years, 8 months ago (2011-04-15 13:54:46 UTC) #2

yurys

http://codereview.chromium.org/6875005/diff/1/test/mjsunit/debug-evaluate-with.js File test/mjsunit/debug-evaluate-with.js (right): http://codereview.chromium.org/6875005/diff/1/test/mjsunit/debug-evaluate-with.js#newcode51 test/mjsunit/debug-evaluate-with.js:51: print(exec_state.frame(0).evaluate('foo').value()); On 2011/04/15 13:54:46, antonm wrote: > print? Done.

9 years, 8 months ago (2011-04-15 13:57:15 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 6875005: Fix debuger evaluation on a breakpoint inside eval (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages