src/x64/lithium-codegen-x64.cc - Issue 6875002: Fix bug in X64 Math.abs optimization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 6875002: Fix bug in X64 Math.abs optimization (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 746d02eda20c872a7be07330144e31dd4d44b998..d8a218106893cba7a3ca978e1508853033710afc 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -2682,7 +2682,9 @@ void LCodeGen::DoMathAbs(LUnaryMathOperation* instr) {

// Smi check.

__ JumpIfNotSmi(input_reg, deferred->entry());

+ __ SmiToInteger32(input_reg, input_reg);

EmitIntegerMathAbs(instr);

+ __ Integer32ToSmi(input_reg, input_reg);

__ bind(deferred->exit());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »