net/socket/ssl_client_socket_nss.cc - Issue 6874039: Return the constructed certificate chain in X509Certificate::Verify()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 6874039: Return the constructed certificate chain in X509Certificate::Verify() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ensure the EE cert is marked as a TLS server cert, not a CA cert Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_nss.cc

diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc

index 6f6cafef85d2d7516a77bad47b41f42f76f188a3..910fb99cf56d81b30e8740accfd0f91f5209c336 100644

--- a/net/socket/ssl_client_socket_nss.cc

+++ b/net/socket/ssl_client_socket_nss.cc

@@ -512,13 +512,13 @@ void SSLClientSocketNSS::ClearSessionCache() {

void SSLClientSocketNSS::GetSSLInfo(SSLInfo* ssl_info) {

EnterFunction("");

ssl_info->Reset();

- if (!server_cert_)

+ if (!server_cert_verify_result_->verified_cert) {

+ NOTREACHED();

return;

+ }

ssl_info->cert_status = server_cert_verify_result_->cert_status;

- DCHECK(server_cert_ != NULL);

- ssl_info->cert = server_cert_;

+ ssl_info->cert = server_cert_verify_result_->verified_cert;

ssl_info->connection_status = ssl_connection_status_;

ssl_info->public_key_hashes = server_cert_verify_result_->public_key_hashes;

ssl_info->is_issued_by_known_root =