Return the constructed certificate chain in X509Certificate::Verify()

net/base/x509_certificate.cc

Index: net/base/x509_certificate.cc
diff --git a/net/base/x509_certificate.cc b/net/base/x509_certificate.cc
index 9fbf702d96aefb418f1996da61f08d0470cf7c49..5ff8869a9866dded17ae24e492cda4eab88b18ff 100644
--- a/net/base/x509_certificate.cc
+++ b/net/base/x509_certificate.cc
@@ -592,6 +592,8 @@ bool X509Certificate::VerifyHostname(
 int X509Certificate::Verify(const std::string& hostname, int flags,
                             CertVerifyResult* verify_result) const {
   verify_result->Reset();
+  verify_result->verified_cert =
+      CreateFromHandle(cert_handle_, intermediate_ca_certs_);

[wtc, 2011/07/26 19:32:29]

Since X509Certificate is reference-counted, I think you
can just say
  verify_result->verified_cert = this;

It doesn't seem necessary to construct a copy of the
current X509Certificate object.

[Ryan Sleevi, 2011/07/26 23:28:31]

This came up on discussion on IRC yesterday, as I was exploring doing this.
Though RefCountedThreadSafe::AddRef() and Release() are const, because this is
in a const method, I have a (const X509Certificate*) |this|.

Obviously, I can get away with it by doing const_cast<X509Certificate*>(this),
but that seemed a violation of the API, particularly with where sergeyu was
heading towards refactoring.

That said, because all of X509Certificate is initialized at ctor and there are
no non-const methods, I've added the const_cast<>, as this will save some small
amount of memory in the returned chain on error.

 
   if (IsBlacklisted()) {
     verify_result->cert_status |= CERT_STATUS_REVOKED;