Return the constructed certificate chain in X509Certificate::Verify()

net/base/cert_verify_result.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_CERT_VERIFY_RESULT_H_
 #define NET_BASE_CERT_VERIFY_RESULT_H_
 #pragma once
 
 #include <vector>
 
+#include "base/memory/ref_counted.h"
 #include "net/base/x509_cert_types.h"
 
 namespace net {
 
-// The result of certificate verification.  Eventually this may contain the
-// certificate chain that was constructed during certificate verification.
+class X509Certificate;
+
+// The result of certificate verification.
 class CertVerifyResult {
  public:
   CertVerifyResult();
   ~CertVerifyResult();
 
   void Reset();
 
-  // Bitmask of CERT_STATUS_* from net/base/cert_status_flags.h
+  // The certificate and chain that were constructed during verification.

[wtc, 2011/07/26 00:16:35]

Nit: were => was
because only the chain was constructed.

+  // Note that the though the verified certificate will match the originally
+  // supplied certificate, the intermediate certificates stored within may
+  // be substantially different.

[agl, 2011/04/18 13:50:27]

I think it's worth noting that, in the event of a verification failure, this
will contain the chain as supplied by the server.

+  scoped_refptr<X509Certificate> verified_cert;

[wtc, 2011/04/20 23:39:30]

It's better to return a CertificateList to avoid the
confusion.

[Ryan Sleevi, 2011/04/20 23:44:34]

As implemented, this means that the subject, issuer, and validity dates for
every intermediate and root must be parsed, even though they are never accessed
by Chromium on Windows/Mac, and the parsed results are ignored in the Linux/CrOS
certificate viewer in favour of accessing NSS directly.

This is in line with the comments on http://codereview.chromium.org/2944008/ ,
so I'll defer any changes until we discuss the issues raised there.

+
+  // Bitmask of CERT_STATUS_* from net/base/cert_status_flags.h. Note that
+  // these status flags apply to the certificate chain returned in
+  // |verified_certificate|, rather than the originally supplied certificate

[wtc, 2011/07/26 00:16:35]

Typo: verified_certificate => verified_cert

+  // chain.
   int cert_status;
 
   // Properties of the certificate chain.
   bool has_md5;
   bool has_md2;
   bool has_md4;
   bool has_md5_ca;
   bool has_md2_ca;
 
   // If the certificate was successfully verified then this contains the SHA1
   // fingerprints of the SubjectPublicKeyInfos of the chain. The fingerprint
   // from the leaf certificate will be the first element of the vector.
   std::vector<SHA1Fingerprint> public_key_hashes;
 
   // is_issued_by_known_root is true if we recognise the root CA as a standard
   // root.  If it isn't then it's probably the case that this certificate was
   // generated by a MITM proxy whose root has been installed locally. This is
   // meaningless if the certificate was not trusted.
   bool is_issued_by_known_root;
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_CERT_VERIFY_RESULT_H_