Issue 6874035: entd: require a per-entd-invocation session id in every request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6874035: entd: require a per-entd-invocation session id in every request (Closed)

Created:
9 years, 8 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
rginda

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/entd.git@master

Visibility:
Public.

Description

entd: require a per-entd-invocation session id in every request Change-Id: Ic63af59fa1371a0ac4ea9f1576acdab79216afb1 BUG=chromium-os:5813 TEST= old extension / new entd 1) open extension options 2) loading fails with a message about entd not starting, logs indicate failure new extension / old entd 1) open extension options 2) works as expected since all old headers still are sent and new one is ignored new extension / new entd 1) open extension options 2) works as expected - session id is sent in every request as expected by entd Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fb446ee

Patch Set 1 #

Patch Set 2 : few more bug fixes #

Total comments: 1

Patch Set 3 : respond to rginda #

Patch Set 4 : Allow a developer switch to disable session id' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -42 lines)			Patch
M	bin/entdwife.sh	View	1 2 3	2 chunks	+30 lines, -2 lines	0 comments	Download
M	callback_server.h	View	1 2	3 chunks	+10 lines, -10 lines	0 comments	Download
M	callback_server.cc	View		6 chunks	+8 lines, -29 lines	0 comments	Download
M	main.cc	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	reference_extension/client.js	View	1	4 chunks	+37 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rginda

lgtm with one change http://codereview.chromium.org/6874035/diff/2001/callback_server.h File callback_server.h (right): http://codereview.chromium.org/6874035/diff/2001/callback_server.h#newcode83 callback_server.h:83: static void SetSessionId(const std::string& session_id) ...

9 years, 8 months ago (2011-04-18 16:55:20 UTC) #2

kmixter1

9 years, 8 months ago (2011-04-19 17:36:13 UTC) #3

pushing... (added code to look for /root/.disable-entd-session-id and disable
session-ids)

Expand Messages | Collapse Messages