Issue 6874030: Commit Instant if needed before handling a web page context menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6874030: Commit Instant if needed before handling a web page context menu. (Closed)

Created:
9 years, 8 months ago by mafv

Modified:
9 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews, Avi (use Gerrit), pam+watch_chromium.org, brettw-cc_chromium.org, sky, rohitbm

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Commit Instant if needed before handling a web page context menu. Avoids the situation where contextual menu commands like "Open Link in New Tab" get ignored, because it's being handled with the Instant dummy loader still in place. BUG=73259 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81886

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
M	chrome/browser/tab_contents/render_view_context_menu_mac.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu_mac.mm	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages