Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 6874019: Enable PrintWebViewHelper::OnPrintForPrintPreview on all platforms. (Closed)

Created:
9 years, 8 months ago by Chris Guillory
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, arthurhsu
Visibility:
Public.

Description

Enable PrintWebViewHelper::OnPrintForPrintPreview on all platforms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81832

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/renderer/print_web_view_helper.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Guillory
9 years, 8 months ago (2011-04-15 20:23:29 UTC) #1
Lei Zhang
Can you just get rid of the #ifdef all together? Linux is almost ready.
9 years, 8 months ago (2011-04-15 20:26:55 UTC) #2
Chris Guillory
Done.
9 years, 8 months ago (2011-04-15 20:44:22 UTC) #3
Lei Zhang
9 years, 8 months ago (2011-04-15 20:54:06 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698