Move crypto_helpers from sync to base

crypto/md5_calculator.h

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_SYNC_UTIL_CRYPTO_HELPERS_H_
-#define CHROME_BROWSER_SYNC_UTIL_CRYPTO_HELPERS_H_
+#ifndef CRYPTO_MD5_CALCULATOR_H_
+#define CRYPTO_MD5_CALCULATOR_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
-// An object to handle calculation of MD5 sums.
 #include "base/basictypes.h"
 #include "base/md5.h"
 #include "base/port.h"
+#include "base/string_number_conversions.h"
+#include "base/string_util.h"
 
+// An object to handle calculation of MD5 sums.
 class MD5Calculator {

[agl, 2011/04/26 13:59:37]

I'm afraid that this wrapper object is too thin to be worthwhile. The (single?)
user should simply be updated to use the underlying base/md5.h because this adds
almost nothing.

  protected:
   MD5Context context_;
   std::vector<uint8> bin_digest_;
 
   void CalcDigest();
  public:
   MD5Calculator();
   ~MD5Calculator();
   void AddData(const uint8* data, int length);
   void AddData(const char* data, int length) {
     AddData(reinterpret_cast<const uint8*>(data), length);
   }
   std::string GetHexDigest();
   const std::vector<uint8>& GetDigest();
  private:
   DISALLOW_COPY_AND_ASSIGN(MD5Calculator);
 };
 
-void GetRandomBytes(char* output, int output_length);
-std::string Generate128BitRandomHexString();
-
-#endif  // CHROME_BROWSER_SYNC_UTIL_CRYPTO_HELPERS_H_
+#endif  // CRYPTO_MD5_CALCULATOR_H_