Move crypto_helpers from sync to base

base/rand_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_RAND_UTIL_H_
 #define BASE_RAND_UTIL_H_
 #pragma once
 
 #include <string>
 
@@ skipping 11 matching lines @@
 // Returns a random number in range [0, max).  Thread-safe.
 //
 // Note that this can be used as an adapter for std::random_shuffle():
 // Given a pre-populated |std::vector<int> myvector|, shuffle it as
 //   std::random_shuffle(myvector.begin(), myvector.end(), base::RandGenerator);
 BASE_API uint64 RandGenerator(uint64 max);
 
 // Returns a random double in range [0, 1). Thread-safe.
 BASE_API double RandDouble();
 
+// fills |output_length| bytes of |output| with cryptographically strong random

[brettw, 2011/05/03 17:36:53]

Be sure all comments are complete sentences with capital letters.

+// data.
+BASE_API void RandBytes(void* output, size_t output_length);
+
 // Returns a random string of the specified length.
 BASE_API std::string RandBytesAsString(size_t length);

[brettw, 2011/05/03 17:36:53]

Can you update the comment for this function so it's more clear that this is the
same as RandBytes, just with a different return type?

 
 }  // namespace base
 
 #endif  // BASE_RAND_UTIL_H_