Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 6873134: cros_make_image_bootable: default to verity_depth=0 (Closed)

Created:
9 years, 8 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

cros_make_image_bootable: default to verity_depth=0 Verity only supports a depth of 0. Passing anything other than 0 will cause a verity failure. BUG=14314 TEST=Verified that verity does not fail when do depth is passed. Before this change, verity would fail with the error message reported in the bug. Change-Id: I68495c4486284744ee0779b6c9cdc0ef214519c7 R=gauravsh@google.com,scottz@google.com,drewry@google.com Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9502695

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed per review. #

Patch Set 3 : Fix. #

Total comments: 1

Patch Set 4 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M bin/cros_make_image_bootable View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mandeep Singh Baines
9 years, 8 months ago (2011-04-20 22:28:08 UTC) #1
gauravsh
http://codereview.chromium.org/6873134/diff/1/bin/cros_make_image_bootable File bin/cros_make_image_bootable (right): http://codereview.chromium.org/6873134/diff/1/bin/cros_make_image_bootable#newcode100 bin/cros_make_image_bootable:100: DEFINE_integer verity_depth 0 \ Add a TODO referencing a ...
9 years, 8 months ago (2011-04-20 22:29:26 UTC) #2
gauravsh
http://codereview.chromium.org/6873134/diff/6001/bin/cros_make_image_bootable File bin/cros_make_image_bootable (right): http://codereview.chromium.org/6873134/diff/6001/bin/cros_make_image_bootable#newcode100 bin/cros_make_image_bootable:100: #TODO(msb) remove this option (http://crosbug.com/14357) nit: space between # ...
9 years, 8 months ago (2011-04-20 22:44:25 UTC) #3
gauravsh
LGTM other than the nit
9 years, 8 months ago (2011-04-20 22:45:13 UTC) #4
scottz-goog
9 years, 8 months ago (2011-04-20 23:20:20 UTC) #5
LGTM, 

submit it!

On 2011/04/20 22:45:13, gauravsh wrote:
> LGTM other than the nit

Powered by Google App Engine
This is Rietveld 408576698