Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 6873075: Lithium LLabel instruction are no longer used as gap instructions. (Closed)

Created:
9 years, 8 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Lithium LLabel instruction are no longer used as gap instructions. Instead we use the first part of the first gap after the label to insert gap-moves for resolving control-flow and phis. Committed: http://code.google.com/p/v8/source/detail?r=7665

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -30 lines) Patch
M src/arm/lithium-arm.h View 3 chunks +9 lines, -4 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 3 chunks +9 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/lithium-allocator.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-x64.h View 3 chunks +9 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fschneider
9 years, 8 months ago (2011-04-19 14:55:13 UTC) #1
Vyacheslav Egorov (Chromium)
LGTM http://codereview.chromium.org/6873075/diff/1/src/lithium-allocator.cc File src/lithium-allocator.cc (right): http://codereview.chromium.org/6873075/diff/1/src/lithium-allocator.cc#newcode1126 src/lithium-allocator.cc:1126: LGap* gap = NULL; you can duplicate&move this ...
9 years, 8 months ago (2011-04-19 15:01:07 UTC) #2
fschneider
Addressed comments and uploaded 3 missing files. http://codereview.chromium.org/6873075/diff/1/src/lithium-allocator.cc File src/lithium-allocator.cc (right): http://codereview.chromium.org/6873075/diff/1/src/lithium-allocator.cc#newcode1126 src/lithium-allocator.cc:1126: LGap* gap ...
9 years, 8 months ago (2011-04-19 16:01:05 UTC) #3
Vyacheslav Egorov (Chromium)
9 years, 8 months ago (2011-04-19 16:10:59 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698