[Sync] Revamp and re-enable themes/extensions sync integration tests

[Sync] Revamp and re-enable themes/extensions sync integration tests

Remove LiveExtensionsSyncTestBase and replace it with
LiveExtensionSyncHelper.

Distinguish extensions with the same ID but installed on different profiles.

Reenable all disabled tests.

BUG=70028, 66925
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82089

[akalin, 2011-04-19 02:15:38]

+rsimha for review

[Raghu Simha, 2011-04-19 04:20:04]

Very cool work! LGTM with a couple of minor concerns, involving the positioning
of ASSERTs.

http://codereview.chromium.org/6873061/diff/29/chrome/test/live_sync/two_clie...
File chrome/test/live_sync/two_client_live_themes_sync_test.cc (right):

http://codereview.chromium.org/6873061/diff/29/chrome/test/live_sync/two_clie...
chrome/test/live_sync/two_client_live_themes_sync_test.cc:32:
ASSERT_FALSE(UsingCustomTheme(GetProfile(1)));
It's possible that sync could be complete even before you call
AwaitMutualSyncCycleCompletion, if a previous action runs the message loop. In
this particular case, I think you should be fine, since
UsingCustomTheme(GetProfile(1)) will be false even after sync is complete.
However, it might be worth placing a similar check after
AwaitMutualSyncCycleCompletion to be sure.

http://codereview.chromium.org/6873061/diff/29/chrome/test/live_sync/two_clie...
chrome/test/live_sync/two_client_live_themes_sync_test.cc:57:
ASSERT_FALSE(UsingNativeTheme(GetProfile(1)));
This may or may not be false, depending on whether a sync cycle managed to sneak
in during a previous run of the message loop.

http://codereview.chromium.org/6873061/diff/29/chrome/test/live_sync/two_clie...
chrome/test/live_sync/two_client_live_themes_sync_test.cc:79:
ASSERT_FALSE(UsingDefaultTheme(GetProfile(1)));
Same concern here, as described in the above comment.

[akalin, 2011-04-19 06:48:16]

All comments addressed, submitting once trybots pass

http://codereview.chromium.org/6873061/diff/29/chrome/test/live_sync/two_clie...
File chrome/test/live_sync/two_client_live_themes_sync_test.cc (right):

http://codereview.chromium.org/6873061/diff/29/chrome/test/live_sync/two_clie...
chrome/test/live_sync/two_client_live_themes_sync_test.cc:32:
ASSERT_FALSE(UsingCustomTheme(GetProfile(1)));
On 2011/04/19 04:20:05, rsimha wrote:
> It's possible that sync could be complete even before you call
> AwaitMutualSyncCycleCompletion, if a previous action runs the message loop. In
> this particular case, I think you should be fine, since
> UsingCustomTheme(GetProfile(1)) will be false even after sync is complete.
> However, it might be worth placing a similar check after
> AwaitMutualSyncCycleCompletion to be sure.

Done.

http://codereview.chromium.org/6873061/diff/29/chrome/test/live_sync/two_clie...
chrome/test/live_sync/two_client_live_themes_sync_test.cc:57:
ASSERT_FALSE(UsingNativeTheme(GetProfile(1)));
On 2011/04/19 04:20:05, rsimha wrote:
> This may or may not be false, depending on whether a sync cycle managed to
sneak
> in during a previous run of the message loop.

Done.

http://codereview.chromium.org/6873061/diff/29/chrome/test/live_sync/two_clie...
chrome/test/live_sync/two_client_live_themes_sync_test.cc:79:
ASSERT_FALSE(UsingDefaultTheme(GetProfile(1)));
On 2011/04/19 04:20:05, rsimha wrote:
> Same concern here, as described in the above comment.

Done.