Issue 6873045: Fix the problem that releasing a key after pressing multiple modifiers corrupts keyboard overlay

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6873045: Fix the problem that releasing a key after pressing multiple modifiers corrupts keyboard overlay (Closed)

Created:
9 years, 8 months ago by hashimoto

Modified:
9 years, 7 months ago

Reviewers:
mazda

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Fix the problem that releasing a key after pressing multiple modifiers corrupts keyboard overlay BUG=chromium-os:14237 TEST=tested manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82062

Patch Set 2 : remove redandunt functions, variables #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -27 lines)			Patch
	M	chrome/browser/resources/keyboard_overlay.js	View	1	4 chunks	+21 lines, -27 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mazda

lgtm with nits. http://codereview.chromium.org/6873045/diff/1/chrome/browser/resources/keyboard_overlay.js File chrome/browser/resources/keyboard_overlay.js (right): http://codereview.chromium.org/6873045/diff/1/chrome/browser/resources/keyboard_overlay.js#newcode125 chrome/browser/resources/keyboard_overlay.js:125: var modifiers = []; Please move ...

9 years, 8 months ago (2011-04-18 11:00:20 UTC) #2

Expand Messages | Collapse Messages

Issue 6873045: Fix the problem that releasing a key after pressing multiple modifiers corrupts keyboard overlay (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove redandunt functions, variables #

Messages