Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1830)

Unified Diff: content/renderer/render_view.h

Issue 6873040: Move the content settings code out of RenderView, since it belongs in the Chrome layer. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view.h
===================================================================
--- content/renderer/render_view.h (revision 81920)
+++ content/renderer/render_view.h (working copy)
@@ -21,7 +21,6 @@
#include "base/observer_list.h"
#include "base/timer.h"
#include "build/build_config.h"
-#include "chrome/common/content_settings.h"
#include "chrome/common/search_provider.h"
#include "chrome/common/view_types.h"
#include "content/renderer/renderer_webcookiejar_impl.h"
@@ -273,10 +272,6 @@
bool ScheduleFileChooser(const ViewHostMsg_RunFileChooser_Params& params,
WebKit::WebFileChooserCompletion* completion);
- // Sets the content settings that back allowScripts(), allowImages(), and
- // allowPlugins().
- void SetContentSettings(const ContentSettings& settings);
-
// Notifies the browser that the given action has been performed. This is
// aggregated to the user metrics service.
void UserMetricsRecordAction(const std::string& action);
@@ -453,8 +448,6 @@
virtual WebKit::WebCookieJar* cookieJar(WebKit::WebFrame* frame);
virtual void frameDetached(WebKit::WebFrame* frame);
virtual void willClose(WebKit::WebFrame* frame);
- virtual bool allowImages(WebKit::WebFrame* frame, bool enabled_per_settings);
- virtual bool allowPlugins(WebKit::WebFrame* frame, bool enabled_per_settings);
virtual void loadURLExternally(WebKit::WebFrame* frame,
const WebKit::WebURLRequest& request,
WebKit::WebNavigationPolicy policy);
@@ -538,6 +531,8 @@
const WebKit::WebSecurityOrigin& origin,
const WebKit::WebURL& target);
+ virtual bool allowImages(WebKit::WebFrame* frame, bool enabled_per_settings);
+ virtual bool allowPlugins(WebKit::WebFrame* frame, bool enabled_per_settings);
virtual bool allowScript(WebKit::WebFrame* frame, bool enabled_per_settings);
virtual bool allowDatabase(WebKit::WebFrame* frame,
const WebKit::WebString& name,
@@ -657,7 +652,6 @@
FRIEND_TEST_ALL_PREFIXES(RenderViewTest, MacTestCmdUp);
#endif
- typedef std::map<GURL, ContentSettings> HostContentSettings;
typedef std::map<GURL, double> HostZoomLevels;
// Identifies an accessibility notification from webkit.
@@ -831,9 +825,6 @@
void OnSetActive(bool active);
void OnSetAltErrorPageURL(const GURL& gurl);
void OnSetBackground(const SkBitmap& background);
- void OnSetContentSettingsForLoadingURL(
- const GURL& url,
- const ContentSettings& content_settings);
void OnSetWebUIProperty(const std::string& name, const std::string& value);
void OnSetEditCommandsForNextKeyEvent(const EditCommands& edit_commands);
void OnSetInitialFocus(bool reverse);
@@ -866,10 +857,6 @@
// Misc private functions ----------------------------------------------------
- // Helper method that returns if the user wants to block content of type
- // |content_type|.
- bool AllowContentType(ContentSettingsType settings_type);
-
void AltErrorPageFinished(WebKit::WebFrame* frame,
const WebKit::WebURLError& original_error,
const std::string& html);
@@ -882,9 +869,6 @@
// by preferred_size_change_timer_.
void CheckPreferredSize();
- // Resets the |content_blocked_| array.
- void ClearBlockedContentSettings();
-
// Create a new NPAPI plugin.
WebKit::WebPlugin* CreateNPAPIPlugin(WebKit::WebFrame* frame,
const WebKit::WebPluginParams& params,
@@ -898,13 +882,6 @@
const FilePath& path,
webkit::ppapi::PluginModule* pepper_module);
- // Sends an IPC notification that the specified content type was blocked.
- // If the content type requires it, |resource_identifier| names the specific
- // resource that was blocked (the plugin path in the case of plugins),
- // otherwise it's the empty string.
- void DidBlockContentType(ContentSettingsType settings_type,
- const std::string& resource_identifier);
-
// This callback is triggered when DownloadFavicon completes, either
// succesfully or with a failure. See DownloadFavicon for more
// details.
@@ -985,7 +962,6 @@
WebPreferences webkit_preferences_;
RendererPreferences renderer_preferences_;
- HostContentSettings host_content_settings_;
HostZoomLevels host_zoom_levels_;
// Whether content state (such as form state, scroll position and page
@@ -993,9 +969,6 @@
// false, but set to true by some tests.
bool send_content_state_immediately_;
- // Stores if loading of images, scripts, and plugins is allowed.
- ContentSettings current_content_settings_;
-
// Bitwise-ORed set of extra bindings that have been enabled. See
// BindingsPolicy for details.
int enabled_bindings_;
@@ -1049,9 +1022,6 @@
// It is empty if there is no top-level client-side redirect.
GURL completed_client_redirect_src_;
- // Stores if images, scripts, and plugins have actually been blocked.
- bool content_blocked_[CONTENT_SETTINGS_NUM_TYPES];
-
// Holds state pertaining to a navigation that we initiated. This is held by
// the WebDataSource::ExtraData attribute. We use pending_navigation_state_
// as a temporary holder for the state until the WebDataSource corresponding

Powered by Google App Engine
This is Rietveld 408576698