Add a tool that estimates the size of a file after all #includes have been resolved.

Add a tool that estimates the size of a file after all #includes have been resolved.

This is meant to be used mostly to measure how much IWYU saves on some files, so that we can brag about it.

Based on an almost identical script by jyrki@google.com (Jyrki Alakuijala)

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82006

[Nico, 2011-04-18 21:00:31]

Is this useful?

cc'ing folks who might care about this. I learned that browser.h is only 800kB,
which is smaller than I expected.

[Nico, 2011-04-18 21:01:38]

(forgot some ccs)

[James Hawkins, 2011-04-18 21:04:06]

On 2011/04/18 21:01:38, Nico wrote:
> (forgot some ccs)

I do think this is useful. As an added data point, after doing a full run of
iwyu over the entire code base (mostly reverting third_party), the linux Release
binary was reduced by 16k, which is like 0.06%.

[Evan Martin, 2011-04-18 21:05:55]

There's little harm in checking it in, right?  Better than losing it...

http://codereview.chromium.org/6873034/diff/3/tools/include_tracer.py
File tools/include_tracer.py (right):

http://codereview.chromium.org/6873034/diff/3/tools/include_tracer.py#newcode2
tools/include_tracer.py:2: # Copyright 2011 Google Inc.
I think you need to fix this to the official licence block.

http://codereview.chromium.org/6873034/diff/3/tools/include_tracer.py#newcode145
tools/include_tracer.py:145: def Walk(seen, filename, parent, indent):
docstrings?

http://codereview.chromium.org/6873034/diff/3/tools/include_tracer.py#newcode186
tools/include_tracer.py:186: return total_bytes + len("".join(lines))
Can you add some whitespace to this function?  It is hard to read.  :)

[Nico, 2011-04-18 21:20:23]

http://codereview.chromium.org/6873034/diff/3/tools/include_tracer.py
File tools/include_tracer.py (right):

http://codereview.chromium.org/6873034/diff/3/tools/include_tracer.py#newcode2
tools/include_tracer.py:2: # Copyright 2011 Google Inc.
On 2011/04/18 21:05:55, Evan Martin wrote:
> I think you need to fix this to the official licence block.

Done.

http://codereview.chromium.org/6873034/diff/3/tools/include_tracer.py#newcode145
tools/include_tracer.py:145: def Walk(seen, filename, parent, indent):
On 2011/04/18 21:05:55, Evan Martin wrote:
> docstrings?

Done.

http://codereview.chromium.org/6873034/diff/3/tools/include_tracer.py#newcode186
tools/include_tracer.py:186: return total_bytes + len("".join(lines))
On 2011/04/18 21:05:55, Evan Martin wrote:
> Can you add some whitespace to this function?  It is hard to read.  :)

Done.

[Evan Martin, 2011-04-18 21:46:47]

LGTM minus sort-headers

http://codereview.chromium.org/6873034/diff/4002/tools/include_tracer.py
File tools/include_tracer.py (right):

http://codereview.chromium.org/6873034/diff/4002/tools/include_tracer.py#newc...
tools/include_tracer.py:2: # Copyright (c) 2010 The Chromium Authors. All rights
reserved.
2011

http://codereview.chromium.org/6873034/diff/4002/tools/sort-headers.py
File tools/sort-headers.py (right):

http://codereview.chromium.org/6873034/diff/4002/tools/sort-headers.py#newcode4
tools/sort-headers.py:4: # found in the LICENSE file.
Probably didn't mean to include this (?)

[Nico, 2011-04-18 21:54:28]

reverted the sort-headers change

http://codereview.chromium.org/6873034/diff/4002/tools/include_tracer.py
File tools/include_tracer.py (right):

http://codereview.chromium.org/6873034/diff/4002/tools/include_tracer.py#newc...
tools/include_tracer.py:2: # Copyright (c) 2010 The Chromium Authors. All rights
reserved.
On 2011/04/18 21:46:47, Evan Martin wrote:
> 2011

Done.

http://codereview.chromium.org/6873034/diff/4002/tools/sort-headers.py
File tools/sort-headers.py (right):

http://codereview.chromium.org/6873034/diff/4002/tools/sort-headers.py#newcode4
tools/sort-headers.py:4: # found in the LICENSE file.
On 2011/04/18 21:46:47, Evan Martin wrote:
> Probably didn't mean to include this (?)

I opened this file to copy the license header, and noticed that there wasn't
any, so I added it. Do you a) disagree with the header b) with this change being
in this cl c) d?

[Evan Martin, 2011-04-18 21:55:12]

On 2011/04/18 21:54:28, Nico wrote:
> I opened this file to copy the license header, and noticed that there wasn't
> any, so I added it. Do you a) disagree with the header b) with this change
being
> in this cl c) d?

Mostly (b), but you also got the date wrong on it.  ;)

[viettrungluu, 2011-04-19 00:16:30]

http://codereview.chromium.org/6873034/diff/5006/tools/include_tracer.py
File tools/include_tracer.py (right):

http://codereview.chromium.org/6873034/diff/5006/tools/include_tracer.py#newc...
tools/include_tracer.py:197: bytes = Walk(set(), sys.argv[1], '', 0)
Is it so hard to iterate over the arguments, so people can use command-line
globbing?

[Nico, 2011-04-19 00:18:53]

On Mon, Apr 18, 2011 at 5:16 PM,  <viettrungluu@chromium.org> wrote:
>
> http://codereview.chromium.org/6873034/diff/5006/tools/include_tracer.py
> File tools/include_tracer.py (right):
>
>
http://codereview.chromium.org/6873034/diff/5006/tools/include_tracer.py#newc...
> tools/include_tracer.py:197: bytes = Walk(set(), sys.argv[1], '', 0)
> Is it so hard to iterate over the arguments, so people can use
> command-line globbing?

I don't think the output is useful for more than 1 file.