Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 6873021: Test CrosDisks DBus API (Closed)

Created:
9 years, 8 months ago by Ben Chan
Modified:
9 years, 7 months ago
Reviewers:
rtc
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Test CrosDisks DBus API BUG=chromium-os:13698 TEST=Ran platform_CrosDisksDBus test on a VM Change-Id: Icb7e2b48a8233934b60f7d5db061f123fc17267a R=rtc@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c4e2964

Patch Set 1 #

Total comments: 1

Patch Set 2 : refactor tests #

Patch Set 3 : Update tests based on changes in CrosDisks DBus API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -5 lines) Patch
M client/site_tests/platform_CrosDisksDBus/platform_CrosDisksDBus.py View 1 2 1 chunk +110 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ben Chan
9 years, 8 months ago (2011-04-15 22:53:30 UTC) #1
rtc
http://codereview.chromium.org/6873021/diff/1/client/site_tests/platform_CrosDisksDBus/platform_CrosDisksDBus.py File client/site_tests/platform_CrosDisksDBus/platform_CrosDisksDBus.py (right): http://codereview.chromium.org/6873021/diff/1/client/site_tests/platform_CrosDisksDBus/platform_CrosDisksDBus.py#newcode68 client/site_tests/platform_CrosDisksDBus/platform_CrosDisksDBus.py:68: # Check if CrosDisks server is alive. Can you ...
9 years, 8 months ago (2011-04-18 20:29:13 UTC) #2
Ben Chan
9 years, 8 months ago (2011-04-18 20:49:58 UTC) #3
rtc
LGTM
9 years, 8 months ago (2011-04-19 02:49:19 UTC) #4
Ben Chan
9 years, 8 months ago (2011-04-22 18:36:57 UTC) #5
rtc
9 years, 8 months ago (2011-04-25 18:27:25 UTC) #6
 LGTM

On Fri, Apr 22, 2011 at 11:36 AM, <benchan@chromium.org> wrote:

> http://codereview.chromium.org/6873021/
>

Powered by Google App Engine
This is Rietveld 408576698