Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9324)

Unified Diff: chrome/renderer/chrome_render_view_observer.h

Issue 6873014: Clear RenderThread of any Chrome specific code, and move a bunch of stuff out of RenderView. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/chrome_render_process_observer.cc ('k') | chrome/renderer/chrome_render_view_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_render_view_observer.h
===================================================================
--- chrome/renderer/chrome_render_view_observer.h (revision 81751)
+++ chrome/renderer/chrome_render_view_observer.h (working copy)
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_RENDERER_CHROME_RENDER_OBSERVER_H_
-#define CHROME_RENDERER_CHROME_RENDER_OBSERVER_H_
+#ifndef CHROME_RENDERER_CHROME_RENDER_VIEW_OBSERVER_H_
+#define CHROME_RENDERER_CHROME_RENDER_VIEW_OBSERVER_H_
#pragma once
#include "base/task.h"
@@ -12,6 +12,7 @@
class SkBitmap;
class TranslateHelper;
struct ThumbnailScore;
+struct ViewMsg_Navigate_Params;
namespace WebKit {
class WebView;
@@ -23,14 +24,14 @@
// This class holds the Chrome specific parts of RenderView, and has the same
// lifetime.
-class ChromeRenderObserver : public RenderViewObserver {
+class ChromeRenderViewObserver : public RenderViewObserver {
public:
// translate_helper and/or phishing_classifier can be NULL.
- ChromeRenderObserver(
+ ChromeRenderViewObserver(
RenderView* render_view,
TranslateHelper* translate_helper,
safe_browsing::PhishingClassifierDelegate* phishing_classifier);
- virtual ~ChromeRenderObserver();
+ virtual ~ChromeRenderViewObserver();
private:
// RenderViewObserver implementation.
@@ -40,6 +41,7 @@
bool is_new_navigation) OVERRIDE;
void OnCaptureSnapshot();
+ void OnNavigate(const ViewMsg_Navigate_Params& params);
// Captures the thumbnail and text contents for indexing for the given load
// ID. If the view's load ID is different than the parameter, this call is
@@ -66,14 +68,15 @@
// Has the same lifetime as us.
TranslateHelper* translate_helper_;
safe_browsing::PhishingClassifierDelegate* phishing_classifier_;
-
+
// Page_id from the last page we indexed. This prevents us from indexing the
// same page twice in a row.
int32 last_indexed_page_id_;
- ScopedRunnableMethodFactory<ChromeRenderObserver> page_info_method_factory_;
+ ScopedRunnableMethodFactory<ChromeRenderViewObserver>
+ page_info_method_factory_;
- DISALLOW_COPY_AND_ASSIGN(ChromeRenderObserver);
+ DISALLOW_COPY_AND_ASSIGN(ChromeRenderViewObserver);
};
-#endif // CHROME_RENDERER_CHROME_OBSERVER_H_
+#endif // CHROME_RENDERER_CHROME_RENDER_VIEW_OBSERVER_H_
« no previous file with comments | « chrome/renderer/chrome_render_process_observer.cc ('k') | chrome/renderer/chrome_render_view_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698